perf: use line tables only and make profiling optional #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
=====================================
Coverage 80.7% 80.7%
=====================================
Files 126 126
Lines 22397 22397
=====================================
Hits 18089 18089
Misses 4308 4308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
reviewed
Oct 7, 2025
Cargo.toml
Outdated
Comment on lines
15
to
16
| [profile.bench] | ||
| # https://doc.rust-lang.org/cargo/reference/profiles.html#bench | ||
| # https://nnethercote.github.io/perf-book/profiling.html |
Member
There was a problem hiding this comment.
Suggested change
| [profile.bench] | |
| # https://doc.rust-lang.org/cargo/reference/profiles.html#bench | |
| # https://nnethercote.github.io/perf-book/profiling.html | |
| [profile.bench] | |
| # https://doc.rust-lang.org/cargo/reference/profiles.html#debug |
bantonsson
force-pushed
the
ban/make-bench-profiling-optional
branch
from
fed8313 to
4ae1c50
Compare
bantonsson
added a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
…y#3150) Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Switches the
benchprofile toline-tables-only, thecriterion::blackboxtostd::hint::blackboxand makes the profiling of benchmarks optional behind a feature flag.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes