Skip to content

fix: Add std feature to serde to fix CI linting issues - #3165

Merged
lalitb merged 2 commits into
open-telemetry:mainfrom
lucamuscat:fix-ci
Sep 15, 2025
Merged

fix: Add std feature to serde to fix CI linting issues#3165
lalitb merged 2 commits into
open-telemetry:mainfrom
lucamuscat:fix-ci

Conversation

@lucamuscat

@lucamuscat lucamuscat commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Fixes #
Design discussion issue (if applicable) #

Changes

With a recent breaking update in serde (PR #2976), the Deserialize derive attribute now requires std support in order to compile the opentelemetry-proto crate due to some internal logic inside of serde now being moved behind a feature gate.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lucamuscat
lucamuscat requested a review from a team as a code owner September 15, 2025 14:44
@codecov

codecov Bot commented Sep 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.6%. Comparing base (80b5dcb) to head (3e9c6bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3165   +/-   ##
=====================================
  Coverage   80.6%   80.6%           
=====================================
  Files        126     126           
  Lines      22195   22195           
=====================================
  Hits       17898   17898           
  Misses      4297    4297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

With a recent breaking update in serde (PR open-telemetry#2976), the `Deserialize`
derive attribute now requires `std` support in order to compile due to
some internal logic inside of serde now being moved behind a feature
gate.
@lucamuscat lucamuscat changed the title fix: Add std feature to serde to fix linting issues fix: Add std feature to serde to fix CI linting issues Sep 15, 2025
…d-external-types.toml` following the recent breaking changes introduced in serde

@lalitb lalitb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb
lalitb merged commit 6f75c58 into open-telemetry:main Sep 15, 2025
27 checks passed
@lucamuscat
lucamuscat deleted the fix-ci branch September 17, 2025 20:54
takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants