-
Notifications
You must be signed in to change notification settings - Fork 599
chore: upgrade tracing-opentelemetry to 0.32.0 and bump opentelemetry-appender-tracing to 0.31.1 #3184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade tracing-opentelemetry to 0.32.0 and bump opentelemetry-appender-tracing to 0.31.1 #3184
Conversation
…-appender-tracing to 0.31.1 - Update tracing-opentelemetry dependency from 0.31 to 0.32 - Bump opentelemetry-appender-tracing crate version to 0.31.1 - Adjust related dependencies and features for compatibility
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
=======================================
+ Coverage 80.5% 80.7% +0.1%
=======================================
Files 126 126
Lines 22238 22331 +93
=======================================
+ Hits 17921 18023 +102
+ Misses 4317 4308 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We also need to uncomment the code related to experimental_use_tracing_span_context. This was commented out during 0.31.0 release (typical chore to handle the circular dependency as part of every release). |
The annotated code has been modified |
bantonsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fixes @houseme
Not related to these fixes @cijothomas , but the necessary release dance once again highlights why the appenders should be in the contrib repo to avoid this circular dependency on a third party library.
Co-authored-by: Björn Antonsson <[email protected]>
|
@bantonsson @lalitb After the merger, a new version of |
Curious, how will moving to another repo help resolving the circular dependency. |
Done. thanks for the PR. |
@lalitb Moving the appender out of the core repo and not having any dependencies on the appender in the core repo would mean that we can release the core repo artifacts without commenting out anything. Then the As things are now, I can't open a PR for removing fields in the This is not maintainable. I opened #3190 to track this. |
…-appender-tracing to 0.31.1 (open-telemetry#3184)
chore: upgrade tracing-opentelemetry to 0.32.0 and bump opentelemetry-appender-tracing to 0.31.1
cc @cijothomas
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes