Skip to content

Conversation

@houseme
Copy link
Contributor

@houseme houseme commented Oct 1, 2025

chore: upgrade tracing-opentelemetry to 0.32.0 and bump opentelemetry-appender-tracing to 0.31.1

  • Update tracing-opentelemetry dependency from 0.31 to 0.32
  • Bump opentelemetry-appender-tracing crate version to 0.31.1
  • Adjust related dependencies and features for compatibility

cc @cijothomas

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

…-appender-tracing to 0.31.1

- Update tracing-opentelemetry dependency from 0.31 to 0.32
- Bump opentelemetry-appender-tracing crate version to 0.31.1
- Adjust related dependencies and features for compatibility
@houseme houseme requested a review from a team as a code owner October 1, 2025 13:27
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.7%. Comparing base (becad0c) to head (69859ae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-appender-tracing/src/layer.rs 85.7% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3184     +/-   ##
=======================================
+ Coverage   80.5%   80.7%   +0.1%     
=======================================
  Files        126     126             
  Lines      22238   22331     +93     
=======================================
+ Hits       17921   18023    +102     
+ Misses      4317    4308      -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb
Copy link
Member

lalitb commented Oct 1, 2025

We also need to uncomment the code related to experimental_use_tracing_span_context. This was commented out during 0.31.0 release (typical chore to handle the circular dependency as part of every release).

@houseme
Copy link
Contributor Author

houseme commented Oct 2, 2025

We also need to uncomment the code related to experimental_use_tracing_span_context. This was commented out during 0.31.0 release (typical chore to handle the circular dependency as part of every release).

The annotated code has been modified

Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fixes @houseme

Not related to these fixes @cijothomas , but the necessary release dance once again highlights why the appenders should be in the contrib repo to avoid this circular dependency on a third party library.

@houseme
Copy link
Contributor Author

houseme commented Oct 2, 2025

@bantonsson @lalitb After the merger, a new version of 0.31.1 needs to be released for openteletry-appender-tracing. Thanks!

@lalitb
Copy link
Member

lalitb commented Oct 2, 2025

Not related to these fixes @cijothomas , but the necessary release dance once again highlights why the appenders should be in the contrib repo to avoid this circular dependency on a third party library.

Curious, how will moving to another repo help resolving the circular dependency.
-

@lalitb lalitb merged commit 00f97c9 into open-telemetry:main Oct 2, 2025
27 checks passed
@lalitb
Copy link
Member

lalitb commented Oct 2, 2025

@bantonsson @lalitb After the merger, a new version of 0.31.1 needs to be released for openteletry-appender-tracing. Thanks!

Done. thanks for the PR.

@bantonsson
Copy link
Contributor

Curious, how will moving to another repo help resolving the circular dependency.

@lalitb Moving the appender out of the core repo and not having any dependencies on the appender in the core repo would mean that we can release the core repo artifacts without commenting out anything. Then the tracing-opentelemetry repo can release their artifacts, and then the appender can be released. Just like normal dependencies work.

As things are now, I can't open a PR for removing fields in the SpanBuilder in the core repo until I have removed their use in the tracing-opentelemetry repo, and there has been a dot release of tracing-opentelemetry, since the appender in the core repo will fail to build otherwise.

This is not maintainable.

I opened #3190 to track this.

@houseme houseme deleted the feature/tracing-opentelemetry-0.32.0 branch October 3, 2025 16:18
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants