Skip to content

Conversation

houseme
Copy link
Contributor

@houseme houseme commented Oct 9, 2025

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@houseme houseme requested a review from a team as a code owner October 9, 2025 05:43
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (51eac97) to head (5057d94).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3193   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        126     126           
  Lines      22397   22397           
=====================================
  Hits       18089   18089           
  Misses      4308    4308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb
Copy link
Member

lalitb commented Oct 9, 2025

@houseme - Can;t this wait for next minor release ?

@lalitb
Copy link
Member

lalitb commented Oct 9, 2025

approved based on the reasoning here, but we’ll need one more @open-telemetry/rust-maintainers approval before release.

@scottgerring
Copy link
Member

IMHO given the effort involved and potential impact of a new release I think we should wait for 0.32. I also read the referenced message as indicating this is not urgent:

It is recommended to release a fixed version, but it is not mandatory, because when using the gRPC feature in the openteletry-otlp, you do not need to rely on openteletry-http/internal-logs, so you can directly use openteletry-http/internal-logs, which reduces unnecessary dependency on crates.

I think it would be great if we could have easier, quicker, higher-cadence patch releases, but I don't think we're there yet.

@houseme
Copy link
Contributor Author

houseme commented Oct 9, 2025

IMHO given the effort involved and potential impact of a new release I think we should wait for 0.32. I also read the referenced message as indicating this is not urgent:

It is recommended to release a fixed version, but it is not mandatory, because when using the gRPC feature in the openteletry-otlp, you do not need to rely on openteletry-http/internal-logs, so you can directly use openteletry-http/internal-logs, which reduces unnecessary dependency on crates.

I think it would be great if we could have easier, quicker, higher-cadence patch releases, but I don't think we're there yet.

However, I still look forward to a new version released.

@lalitb
Copy link
Member

lalitb commented Oct 9, 2025

@houseme - Can we close this PR, or are you still expecting the patch release?

@houseme houseme closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants