Skip to content

Conversation

@chickenbreeder
Copy link

Fixes #1552

Changes

#[rstest]
#[tokio::test]

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@chickenbreeder chickenbreeder requested a review from a team as a code owner November 22, 2025 11:38
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: chickenbreeder / name: chickenbreeder (a1e2f3a)

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (df412fe) to head (a1e2f3a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3256     +/-   ##
=======================================
- Coverage   80.8%   80.7%   -0.1%     
=======================================
  Files        129     129             
  Lines      23203   23167     -36     
=======================================
- Hits       18750   18714     -36     
  Misses      4453    4453             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring
Copy link
Member

I asked Claude to see if there are many others here we could pick up. Not sure how useful this is, but it's probably worth trying to pick out other instances of this pattern we can clean up!

  1. opentelemetry-zipkin/src/propagator/mod.rs:464-683
    • B3 propagator tests with extensive test data sets
    • Multiple nested loops for single/multi-header formats
    • Could consolidate 20+ test cases
  2. opentelemetry-sdk/src/metrics/internal/exponential_histogram.rs
    - Multiple locations (555-664, 914-1072, 1141-1229)
    - Complex test data structures for bucket calculations
    - 30+ test cases across different test functions
  3. opentelemetry-otlp/src/retry.rs:218-495
    - 10+ similar async test functions for retry logic
    - Each tests different scenarios (success, failure, timeout, throttling)
    - Perfect candidate for #[rstest] with #[case] attributes

@scottgerring scottgerring self-assigned this Nov 22, 2025
@scottgerring
Copy link
Member

@chickenbreeder let me know when you are ready with this!

@scottgerring scottgerring marked this pull request as draft November 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use parameterization to simplify tests

2 participants