refactor: avoid instrumentation_scope clone for every single span processor #3267
+69
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1125
Changes
Optimize
InstrumentationScopehandling by wrapping it inArcinstead of cloning for each span processor.Previously, when a span ended, the
InstrumentationScope(approximately 120 bytes) was cloned once for eachSpanProcessor, causing unnecessary allocations and memory copies. This change wrapsInstrumentationScopeinArcat tracer creation time, so subsequent clones are just atomic reference count increments.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes