chore(sdk): remove tokio runtime from testing feature#3407
Open
CathalMullan wants to merge 2 commits intoopen-telemetry:mainfrom
Open
chore(sdk): remove tokio runtime from testing feature#3407CathalMullan wants to merge 2 commits intoopen-telemetry:mainfrom
CathalMullan wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
=======================================
- Coverage 83.1% 83.1% -0.1%
=======================================
Files 128 128
Lines 24877 24877
=======================================
- Hits 20688 20684 -4
- Misses 4189 4193 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bantonsson
requested changes
Mar 6, 2026
Contributor
bantonsson
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @CathalMullan, only one comment about the change log.
bantonsson
reviewed
Mar 6, 2026
bantonsson
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2643 I suppose.
Changes
The
testingSDK feature doesn't actually need atokioruntime, it's runtime agnostic, so removed it.The
opentelemetry-appender-logchange might look irrelevant, but it's needed since feature unification meant this was previously enabled transitively.This does mean the naming of the
testingtypes is now a little misleading. They could just be called e.g.TestSpanExporterinstead ofTokioSpanExporter. Can rename them here if wanted.EDIT: Actually, since the equivalent metrics type is called
TestMetricReader, I'll go ahead with the rename for consistency.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes