Skip to content

Add default_histogram_aggregation configuration option to prometheus exporter #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add default_histogram_aggregation configuration option to prometheus exporter #4124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions specification/metrics/sdk_exporters/prometheus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,12 @@ metric, or scope labels. The option MAY be named `without_scope_info`, and MUST

A Prometheus Exporter MAY support a configuration option to produce metrics without a [target info](../../compatibility/prometheus_and_openmetrics.md#resource-attributes-1)
metric. The option MAY be named `without_target_info`, and MUST be `false` by default.

A Prometheus Exporter MAY support a configuration option to set the default
histogram aggregation. The option MAY be named `default_histogram_aggregation`,
and MUST support the following values:

* `explicit_bucket_histogram`: Use [Explicit Bucket Histogram Aggregation](../sdk.md#explicit-bucket-histogram-aggregation).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure makes sense for environment-variable-based config, where we expect string constants, but maybe not so much for SDK exporter config? E.g. Go allows users to provide an AggregationSelector, which I don't think would comply with this.

* `base2_exponential_bucket_histogram`: Use [Base2 Exponential Bucket Histogram Aggregation](../sdk.md#base2-exponential-bucket-histogram-aggregation).

By default, `default_histogram_aggregation` MUST be `explicit_bucket_histogram`.