-
Notifications
You must be signed in to change notification settings - Fork 933
Extend the set of attribute value types #4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pellared
wants to merge
78
commits into
open-telemetry:main
Choose a base branch
from
pellared:extend-attrs-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
026fad1
Add empty value to attribute
pellared 1831164
Update changelog
pellared 82e8913
toc
pellared 9cab0c4
fix status
pellared 85db60a
Remove the note that extending attributes is a breaking change
pellared eaea1ea
Update CHANGELOG.md
pellared 25c2c25
Update specification/common/attribute-type-mapping.md
pellared d9ac9f7
Merge branch 'main' into empty-attr
pellared 75b22ad
Merge branch 'main' into empty-attr
pellared c540098
revert breaking change note
pellared 05fa307
Merge branch 'main' into empty-attr
pellared aa3c41c
remove changelog entry
pellared 20043e3
remove "standard attribute" term
pellared bfaf650
merge log attributes and standard attribute types
pellared c17aec6
rename "Attribute Value" to "AnyValue"
pellared 95b049b
mdlint
pellared b98d714
fix links
pellared e55416d
Apply suggestions from code review
pellared 49b41b4
Revert "rename "Attribute Value" to "AnyValue""
pellared db81d62
toc
pellared ad10769
Update specification/common/README.md
pellared cc41e2f
Update specification/common/README.md
pellared 8b029c8
propose Attribute Limits changes
pellared a5851af
format
pellared 52ccb34
remove EOL
pellared 9bd7de9
Merge branch 'main' into extend-attrs
pellared ecebf40
Update specification/common/README.md
pellared abfd063
Update specification/common/README.md
pellared cbe15f5
Apply code review suggestion
pellared 7a3c387
Update specification/common/README.md
pellared f2a508b
format
pellared ee4d8ba
Update specification/common/README.md
pellared 10400ef
add attribute count example
pellared f8236e7
format
pellared d7de5d0
Merge branch 'main' into extend-attrs
pellared 5b46a71
add AnyValue and map<string, AnyValue>
pellared 4a15e7c
update Attribute Limits
pellared 552e997
fix toc
pellared b224937
fix limit rules
pellared 9f04b58
make it development
pellared 61a9a1b
fix OTEP hyperlink
pellared 98fb4ae
fix logs API status
pellared f343e4e
Merge branch 'main' into extend-attrs-dev
pellared 253949f
Apply suggestions from code review
pellared d246e63
Add changelog entry
pellared 9e47faa
mdlint
pellared 1ac516a
Remove "Reuse Standard Attribute" from spec compliance
pellared 2dd712d
fmt
pellared 0230f74
Merge branch 'main' into extend-attrs-dev
pellared a9b711d
Update specification/common/README.md
pellared a1493d4
Update specification/common/README.md
pellared df85700
Update specification/common/README.md
pellared 708686e
Update specification/common/README.md
pellared af80d42
Update specification/common/README.md
pellared dca8512
toc
pellared ec94759
move note about deep nesting
pellared eee4182
Merge branch 'main' into extend-attrs-dev
pellared d4240f2
make compliance-matrix
pellared 9b210ca
note that array and map values carry performance overhead
pellared 851f426
update OTEP per feedback
pellared a5178c6
remove redundant section
pellared 4f92d3d
Update 4485-extending-attributes-to-support-complex-values.md
pellared e3a1a65
Update specification/common/README.md
pellared bf19f4d
Merge branch 'main' into extend-attrs-dev
pellared d7d4eaa
Clarify that for attribute count limit only the top-level attributes …
pellared 4d7c1da
Update oteps/4485-extending-attributes-to-support-complex-values.md
pellared 4b69f1f
Merge branch 'main' into extend-attrs-dev
pellared d756e95
Update specification/common/README.md
pellared 815cf8b
Update CHANGELOG.md
pellared 1174a4a
Merge branch 'main' into extend-attrs-dev
pellared e1386ca
Define equality of map<string, AnyValue>
pellared 703745c
Note that the limits apply only to attributes collections
pellared 9c2136f
Merge branch 'main' into extend-attrs-dev
pellared 0baa88c
Merge branch 'main' into extend-attrs-dev
pellared 42bc422
Merge branch 'main' into extend-attrs-dev
pellared e11dd54
Merge branch 'main' into extend-attrs-dev
pellared 6c8418e
Update specification/common/README.md
pellared 6169089
Merge branch 'main' into extend-attrs-dev
pellared File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.