-
Notifications
You must be signed in to change notification settings - Fork 933
Stabilize LogRecordProcessor.Enabled #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@open-telemetry/php-maintainers @open-telemetry/rust-maintainers @open-telemetry/go-maintainers, PTAL as OTel PHP, Rust, and Go are implementing this part of the specification. |
|
@pellared can you please seek feedback from languages that already implemented it? Just to confirm they are happy with the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This is what I have done here #4717 (comment) 😉 Awaiting approval from a PHP maintainer. I also think we can wait until next spec SIG meeting before merging. |
This demonstrates my reading comprehension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with PHP SIG to stabilize this (we have not implemented it yet)
However, given you already have According to, spec compliance matrix, I supposed to be also awaiting approval from OTel Ruby 😉 However, I am not sure if it is really implemented (see https://github.com/open-telemetry/opentelemetry-ruby/blob/main/logs_sdk/lib/opentelemetry/sdk/logs/log_record_processor.rb and https://github.com/open-telemetry/opentelemetry-ruby/blob/main/logs_api/lib/opentelemetry/logs/logger.rb). I think this is a mistake in the spec compliance matrix. @open-telemetry/ruby-maintainers, PTAL |
Fixes #4458
According to spec compliance matrix this feature is already implemented in 2 languages (Go and Rust; PHP approved, but not implemented yet), even though it is marked as optional.
In OTel Go, the design and implementation of this feature have remained unchanged since 2025-03-05. Since that release, we haven’t received any feedback or proposals suggesting changes.
Given this, I would like to propose stabilizing this feature in the specification. Doing so is also a prerequisite for stabilizing the OTel Go Logs SDK.
From #4458 (comment)
Advanced processing guidelines, they already show how to implement
Enabledand how processors can be composed (e.g. chained).Examples from OTel Go documentation:
More info on use cases, chaining/composing processors, and declarative configuration: #4717 (comment)
Approvals from languages that implement (or plan to implement)
LogRecordProcessor.Enabled: