Skip to content

Conversation

@pellared
Copy link
Member

@pellared pellared commented Oct 30, 2025

Fixes #4458

According to spec compliance matrix this feature is already implemented in 2 languages (Go and Rust; PHP approved, but not implemented yet), even though it is marked as optional.

In OTel Go, the design and implementation of this feature have remained unchanged since 2025-03-05. Since that release, we haven’t received any feedback or proposals suggesting changes.

Given this, I would like to propose stabilizing this feature in the specification. Doing so is also a prerequisite for stabilizing the OTel Go Logs SDK.

From #4458 (comment)

Advanced processing guidelines, they already show how to implement Enabled and how processors can be composed (e.g. chained).

Examples from OTel Go documentation:

More info on use cases, chaining/composing processors, and declarative configuration: #4717 (comment)

Approvals from languages that implement (or plan to implement) LogRecordProcessor.Enabled:

  • OTel Go - APPROVED ✔️
  • OTel Rust - APPROVED ✔️
  • OTel PHP - APPROVED ✔️

@pellared
Copy link
Member Author

@open-telemetry/php-maintainers @open-telemetry/rust-maintainers @open-telemetry/go-maintainers, PTAL as OTel PHP, Rust, and Go are implementing this part of the specification.

@pellared pellared marked this pull request as ready for review October 30, 2025 11:59
@pellared pellared requested review from a team as code owners October 30, 2025 11:59
@tigrannajaryan
Copy link
Member

@pellared can you please seek feedback from languages that already implemented it? Just to confirm they are happy with the feature.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pellared
Copy link
Member Author

pellared commented Oct 30, 2025

@pellared can you please seek feedback from languages that already implemented it? Just to confirm they are happy with the feature.

This is what I have done here #4717 (comment) 😉

Awaiting approval from a PHP maintainer. I also think we can wait until next spec SIG meeting before merging.

@tigrannajaryan
Copy link
Member

@pellared can you please seek feedback from languages that already implemented it? Just to confirm they are happy with the feature.

This is what I have done here #4717 (comment) 😉

This demonstrates my reading comprehension.

@pellared pellared requested a review from trask October 30, 2025 21:04
@pellared pellared added area:sdk Related to the SDK spec:logs Related to the specification/logs directory labels Oct 30, 2025
Copy link
Contributor

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with PHP SIG to stabilize this (we have not implemented it yet)

@pellared
Copy link
Member Author

pellared commented Nov 6, 2025

Ok with PHP SIG to stabilize this (we have not implemented it yet)

However, given you already have Logger.Enabled, I am happy to have your approval!
I updated the PR description to make it clear that it is implemented in 2 languages, but you are also fine with the stabilization.

According to, spec compliance matrix, I supposed to be also awaiting approval from OTel Ruby 😉 However, I am not sure if it is really implemented (see https://github.com/open-telemetry/opentelemetry-ruby/blob/main/logs_sdk/lib/opentelemetry/sdk/logs/log_record_processor.rb and https://github.com/open-telemetry/opentelemetry-ruby/blob/main/logs_api/lib/opentelemetry/logs/logger.rb). I think this is a mistake in the spec compliance matrix. @open-telemetry/ruby-maintainers, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sdk Related to the SDK spec:logs Related to the specification/logs directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize LogRecordProcessor.Enabled

10 participants