Refine the handling of OTEL_RESOURCE_ATTRIBUTES. #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jan 27, 2026
Co-authored-by: Reiley Yang <[email protected]>
jsuereth
approved these changes
Jan 27, 2026
trask
reviewed
Jan 28, 2026
specification/resource/sdk.md
Outdated
Comment on lines
184
to
189
| semi-colon delimited metadata is not supported, i.e.: `key1=value1,key2=value2`. | ||
| All attribute values MUST be considered strings and characters outside the | ||
| `baggage-octet` range MUST be percent-encoded. | ||
| `baggage-octet` range SHOULD be percent-encoded. In the case of errors during the |
Member
There was a problem hiding this comment.
how about
The
OTEL_RESOURCE_ATTRIBUTESenvironment variable will contain a list of key value pairs, represented askey1=value1,key2=value2. All attribute values MUST be considered strings. The,and=characters in keys and values MUST be percent-encoded. Other characters MAY be percent-encoded.
Contributor
Author
|
@trask I applied your feedback along keeping the note regarding failing fast. Also, now there's no mention at all to the Baggage standard. Hope this is fine. |
trask
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4847