Skip to content

Commit 3fd4100

Browse files
author
Ignacio Bonafonte
authored
Merge branch 'main' into zipkin_sn
2 parents dcfd501 + 05616aa commit 3fd4100

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Sources/Exporters/Zipkin/ZipkinTraceExporter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class ZipkinTraceExporter: SpanExporter {
1212

1313
public init(options: ZipkinTraceExporterOptions) {
1414
self.options = options
15-
localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: "Open Telemetry Exporter")
15+
localEndPoint = ZipkinTraceExporter.getLocalZipkinEndpoint(name: options.serviceName)
1616
}
1717

1818
public func export(spans: [SpanData]) -> SpanExporterResultCode {

Sources/OpenTelemetrySdk/Resources/EnvVarResource.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import OpenTelemetryApi
88

99
/// Provides a framework for detection of resource information from the environment variable "OC_RESOURCE_LABELS".
1010
public struct EnvVarResource {
11-
private static let otelResourceAttributesEnv = "OTEL_RESOURCE_ATTRIBUTES_ENV"
11+
private static let otelResourceAttributesEnv = "OTEL_RESOURCE_ATTRIBUTES"
1212
private static let labelListSplitter = Character(",")
1313
private static let labelKeyValueSplitter = Character("=")
1414

Sources/OpenTelemetrySdk/Trace/Propagation/EnvironmentContextPropagator.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import OpenTelemetryApi
1111
*/
1212

1313
public struct EnvironmentContextPropagator: TextMapPropagator {
14-
static let traceParent = "OTEL_TRACE_PARENT"
15-
static let traceState = "OTEL_TRACE_STATE"
14+
static let traceParent = "TRACEPARENT"
15+
static let traceState = "TRACESTATE"
1616
let w3cPropagator = W3CTraceContextPropagator()
1717

1818
public let fields: Set<String> = [traceState, traceParent]

Tests/OpenTelemetrySdkTests/Trace/SpanBuilderSdkTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class SpanBuilderSdkTest: XCTestCase {
238238
}
239239

240240
func testParentEnvironmentContext() {
241-
setenv("OTEL_TRACE_PARENT", "00-ff000000000000000000000000000041-ff00000000000041-01", 1)
241+
setenv("TRACEPARENT", "00-ff000000000000000000000000000041-ff00000000000041-01", 1)
242242
let providerWithEnv = TracerProviderSdk()
243243
let tracerAux = providerWithEnv.get(instrumentationName: "SpanBuilderWithEnvTest")
244244
let parent = tracerAux.spanBuilder(spanName: spanName).setNoParent().setActive(true).startSpan()
@@ -247,7 +247,7 @@ class SpanBuilderSdkTest: XCTestCase {
247247
XCTAssertEqual(parent.context.traceId.hexString, "ff000000000000000000000000000041")
248248
span.end()
249249
parent.end()
250-
unsetenv("OTEL_TRACE_PARENT")
250+
unsetenv("TRACEPARENT")
251251
}
252252

253253
func testParent_timestampConverter() {

0 commit comments

Comments
 (0)