Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Jul 9, 2025

These links changed with the repo dir moves in open-telemetry/opentelemetry-js-contrib#2928

(This follows up on other link fixes earlier today: #7276, #7285)

@trentm trentm requested a review from a team as a code owner July 9, 2025 21:05
@opentelemetrybot opentelemetrybot requested review from a team July 9, 2025 21:06
@github-actions github-actions bot added docs:blog An issue requesting a blog post, or a PR for a new blog post sig:javascript docs:registry labels Jul 9, 2025
@trentm trentm changed the title Fix a number of links to the opentelemetry-js-contrib repo. Fix a number of links to the opentelemetry-js-contrib repo Jul 9, 2025
@trentm
Copy link
Contributor Author

trentm commented Jul 9, 2025

/fix:all

@opentelemetrybot
Copy link
Contributor

@trentm
Copy link
Contributor Author

trentm commented Jul 10, 2025

The Links / REFCACHE updates? check failure includes this output:

...
ERROR: the files above have changed. Locally rerun `npm run test-and-fix` and commit changes

Attempting to run that locally eventually fails for me:

% npm run test-and-fix
...
> _hugo
> hugo --cleanDestinationDir -e dev --buildDrafts --buildFuture --baseURL http://localhost

Total in 5 ms
Error: failed to load modules: module "github.com/FortAwesome/Font-Awesome" not found in "/Users/trentm/tm/opentelemetry.io3/themes/github.com/FortAwesome/Font-Awesome"; either add it as a Hugo Module or store it in "/Users/trentm/tm/opentelemetry.io3/themes".: module does not exist

@opentelemetrybot opentelemetrybot requested a review from a team July 10, 2025 16:35
@trentm
Copy link
Contributor Author

trentm commented Jul 10, 2025

Attempting to run that [npm run test-and-fix] locally eventually fails for me:

This was "resolved" by manually deleting themes/docsy/node_modules, which I guess had incompatible content, then re-running npm install at the top-level. /shrug

Copy link
Member

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny fix. Thanks!

@opentelemetrybot opentelemetrybot requested review from a team July 11, 2025 17:10
@tiffany76 tiffany76 added this pull request to the merge queue Jul 12, 2025
Merged via the queue into open-telemetry:main with commit 115933c Jul 12, 2025
20 checks passed
@trentm trentm deleted the trentm-fix-ojc-links branch July 14, 2025 17:28
sajibAdhi pushed a commit to sajibAdhi/opentelemetry.io that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:blog An issue requesting a blog post, or a PR for a new blog post docs:registry sig:javascript

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants