Skip to content

Exclude exception.escaped from (to-be-stable) artifact #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2025
Merged

Exclude exception.escaped from (to-be-stable) artifact #133

merged 2 commits into from
Jan 10, 2025

Conversation

@trask
Copy link
Member

@trask trask commented Jan 8, 2025 •
edited
Loading

@trask trask requested review from a team as code owners January 8, 2025 22:10
trask
trask commented Jan 8, 2025
View reviewed changes
trask
trask commented Jan 8, 2025
View reviewed changes
@trask trask mentioned this pull request Jan 8, 2025
Merged
@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

@lmolkova
Copy link
Member

lmolkova commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

yeah, this is certainly easier, we can always bring it back (as deprecated) in the incubating artifact later

@trask trask requested a review from jack-berg January 8, 2025 22:35
@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

yeah, this is certainly easier, we can always bring it back (as deprecated) in the incubating artifact later

@jack-berg I reset your approval to make sure you're ok with this

@trask trask merged commit 9514488 into open-telemetry:main Jan 10, 2025
12 checks passed
@trask trask deleted the remove-exception-escaped branch January 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jack-berg jack-berg jack-berg approved these changes

+1 more reviewer

@lmolkova lmolkova lmolkova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @lmolkova @jack-berg