Refactor CI build #328
Merged
Refactor CI build #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Oct 17, 2025
| branches: | ||
| - main | ||
| pull_request: | ||
| - release/* |
There was a problem hiding this comment.
build wasn't running on push to release branch previously
trask
commented
Oct 17, 2025
Comment on lines
+9
to
+10
| build: | ||
| uses: ./.github/workflows/build-common.yml |
There was a problem hiding this comment.
and release workflow wasn't running build
trask
commented
Oct 17, 2025
Comment on lines
+95
to
+107
| - name: Check that API diffs are up to date | ||
| run: | | ||
| # need to "git add" in case any generated files did not already exist | ||
| git add docs/apidiffs/ | ||
| if git diff --cached --quiet | ||
| then | ||
| echo "No diff detected in apidiffs." | ||
| else | ||
| echo "Diff detected in apidiffs - did you run './gradlew jApiCmp'?" | ||
| echo $(git diff --cached --name-only) | ||
| echo $(git diff --cached) | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
this didn't exist previously, which is why #317 is passing even though the apidiffs are wrong after my last push to the PR
laurit
reviewed
Oct 17, 2025
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
for this project building and testing on different oses and java versions might be an overkill
There was a problem hiding this comment.
yeah, I'll send a follow-up to remove the different OSes at least
laurit
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following other Java repos better