Skip to content

Commit 18106a6

Browse files
committed
Add details to affected databases
1 parent d2ed009 commit 18106a6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

docs/database/database-spans.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,10 @@ If the propagator does not provide any value, the instrumentation SHOULD NOT inj
502502
SELECT * FROM songs /*traceparent='00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01',tracestate='congo%3Dt61rcWkgMzE%2Crojo%3D00f067aa0ba902b7'*/
503503
```
504504

505-
Note that adding high cardinality comments, like `traceparent` and `tracestate`, to queries can impact the performance for some database systems, like MySQL. See [this related issue](https://github.com/google/sqlcommenter/issues/284) for more details.
505+
Note that adding high cardinality comments, like `traceparent` and `tracestate`, to queries can impact the performance for some database systems, such as:
506+
507+
- Prepared statements in MySQL. See [this related issue](https://github.com/google/sqlcommenter/issues/284) for more details.
508+
- Oracle and SQL Server for both prepared and non-prepared statements.
506509

507510
- For a query `SELECT * FROM songs` with a custom propagator that injects `service.name` into carrier where `service.name` is `shoppingcart`:
508511

0 commit comments

Comments
 (0)