Skip to content

Commit 62409c0

Browse files
committed
PR feedback
1 parent 73a29a4 commit 62409c0

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

docs/dotnet/dotnet-aspnetcore-metrics.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
336336

337337
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
338338
|---|---|---|---|---|---|
339-
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the part of the app using the pool instance. | `Sockets`; `NamedPipes` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
339+
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the library or subsystem using the memory pool instance. | `kestrel`; `iis` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
340340

341341
**[1] `aspnetcore.memory_pool.owner`:** if owner is specified when the memory pool is created.
342342

@@ -362,7 +362,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
362362

363363
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
364364
|---|---|---|---|---|---|
365-
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the part of the app using the pool instance. | `Sockets`; `NamedPipes` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
365+
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the library or subsystem using the memory pool instance. | `kestrel`; `iis` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
366366

367367
**[1] `aspnetcore.memory_pool.owner`:** if owner is specified when the memory pool is created.
368368

@@ -388,7 +388,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
388388

389389
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
390390
|---|---|---|---|---|---|
391-
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the part of the app using the pool instance. | `Sockets`; `NamedPipes` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
391+
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the library or subsystem using the memory pool instance. | `kestrel`; `iis` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
392392

393393
**[1] `aspnetcore.memory_pool.owner`:** if owner is specified when the memory pool is created.
394394

@@ -414,7 +414,7 @@ All memory pool metrics are reported by the `Microsoft.AspNetCore.MemoryPool` me
414414

415415
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
416416
|---|---|---|---|---|---|
417-
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the part of the app using the pool instance. | `Sockets`; `NamedPipes` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
417+
| [`aspnetcore.memory_pool.owner`](/docs/registry/attributes/aspnetcore.md) | string | The name of the library or subsystem using the memory pool instance. | `kestrel`; `iis` | `Conditionally Required` [1] | ![Development](https://img.shields.io/badge/-development-blue) |
418418

419419
**[1] `aspnetcore.memory_pool.owner`:** if owner is specified when the memory pool is created.
420420

docs/registry/attributes/aspnetcore.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ASP.NET Core attributes
1111
|---|---|---|---|---|
1212
| <a id="aspnetcore-diagnostics-exception-result" href="#aspnetcore-diagnostics-exception-result">`aspnetcore.diagnostics.exception.result`</a> | string | ASP.NET Core exception middleware handling result | `handled`; `unhandled` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
1313
| <a id="aspnetcore-diagnostics-handler-type" href="#aspnetcore-diagnostics-handler-type">`aspnetcore.diagnostics.handler.type`</a> | string | Full type name of the [`IExceptionHandler`](https://learn.microsoft.com/dotnet/api/microsoft.aspnetcore.diagnostics.iexceptionhandler) implementation that handled the exception. | `Contoso.MyHandler` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
14-
| <a id="aspnetcore-memory-pool-owner" href="#aspnetcore-memory-pool-owner">`aspnetcore.memory_pool.owner`</a> | string | The name of the part of the app using the pool instance. | `Sockets`; `NamedPipes` | ![Development](https://img.shields.io/badge/-development-blue) |
14+
| <a id="aspnetcore-memory-pool-owner" href="#aspnetcore-memory-pool-owner">`aspnetcore.memory_pool.owner`</a> | string | The name of the library or subsystem using the memory pool instance. | `kestrel`; `iis` | ![Development](https://img.shields.io/badge/-development-blue) |
1515
| <a id="aspnetcore-rate-limiting-policy" href="#aspnetcore-rate-limiting-policy">`aspnetcore.rate_limiting.policy`</a> | string | Rate limiting policy name. | `fixed`; `sliding`; `token` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
1616
| <a id="aspnetcore-rate-limiting-result" href="#aspnetcore-rate-limiting-result">`aspnetcore.rate_limiting.result`</a> | string | Rate-limiting result, shows whether the lease was acquired or contains a rejection reason | `acquired`; `request_canceled` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
1717
| <a id="aspnetcore-request-is-unhandled" href="#aspnetcore-request-is-unhandled">`aspnetcore.request.is_unhandled`</a> | boolean | Flag indicating if request was handled by the application pipeline. | `true` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |

model/aspnetcore/registry.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,5 +86,5 @@ groups:
8686
- id: aspnetcore.memory_pool.owner
8787
type: string
8888
stability: development
89-
brief: The name of the part of the app using the pool instance.
90-
examples: ["Sockets", "NamedPipes"]
89+
brief: The name of the library or subsystem using the memory pool instance.
90+
examples: ["kestrel", "iis"]

0 commit comments

Comments
 (0)