-
Notifications
You must be signed in to change notification settings - Fork 290
chore: add extended request ID to general AWS Attributes #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add extended request ID to general AWS Attributes #1671
Conversation
5c4c3c6 to
4f6989b
Compare
|
From my understanding, the Docs: https://opentelemetry.io/docs/specs/otel/schemas/file_format_v1.0.0/#span_events-section |
lmolkova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reference this attribute from AWS spans you expect the attribute to be available on - there are quite a few of them defined here https://github.com/open-telemetry/semantic-conventions/blob/main/model/aws/sdk-spans.yml
Also, is it populated by any instrumentations?
I've been maintaining AWS SDK for JavaScript for 5+ years, and was recently added as component owner of it's OpenTelemetry Instrumentation in open-telemetry/opentelemetry-js-contrib#2557. I plan to add the attribute as soon as it's merged and released in semantic convention. AWS SDK for Go Observability solution does use it https://github.com/aws/aws-sdk-go-v2/blob/a164d844a90d8b9f86f8cb827b3fef512eabaabf/service/internal/s3shared/metadata_retriever.go#L53 |
Added in |
|
The ERROR: 1 dead links found in ./docs/system/system-metrics.md !
[✖] https://blogs.oracle.com/linux/post/understanding-linux-kernel-memory-statistics → Status: 0
make: *** [Makefile:72: markdown-link-check] Error 1It's failing for other PRs too:
Can you re-run the workflow? |
Co-authored-by: Trask Stalnaker <[email protected]>
|
@trivikr hi, could you please clarify if this header should be required for all AWS services? In your initial issue, you mentioned that I just opened another issue (before I saw this) because it doesn't seem like Dynamo uses |
Fixes #1670
Changes
Adds extended request ID to general AWS Attributes under
aws.extended_request_idMerge requirement checklist
[chore]