-
Notifications
You must be signed in to change notification settings - Fork 273
Add new Blazor metrics for Net10 #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/dotnet/dotnet-blazor-metrics.md
Outdated
|
||
This article defines semantic conventions for Blazor metrics emitted by .NET components. | ||
|
||
TODO - is this generated ? No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, check out https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#2-update-the-markdown-files and you can use other md files as examples, e.g.
<!-- semconv metric.aspnetcore.routing.match_attempts --> |
we don't have it yaml (yet), but we should document recommended boundaries for histograms - e.g. like here https://github.com/open-telemetry/semantic-conventions/blob/main/docs/dotnet/dotnet-http-metrics.md#metric-httpclientrequesttime_in_queue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm doing something wrong
pavelsavara@SAVARA-DESKTOP:~/dev/semantic-conventions$ make table-generation attribute-registry-generation
docker run --rm \
-u 1000:1000 \
--mount 'type=bind,source=/home/pavelsavara/dev/semantic-conventions/templates,target=/home/weaver/templates,readonly' \
--mount 'type=bind,source=/home/pavelsavara/dev/semantic-conventions/model,target=/home/weaver/source,readonly' \
--mount 'type=bind,source=/home/pavelsavara/dev/semantic-conventions/docs,target=/home/weaver/target' \
docker.io/otel/weaver:v0.16.1@sha256:5ca4901b460217604ddb83feaca05238e2b016a226ecfb9b87a95555918a03af registry update-markdown \
--registry=/home/weaver/source \
-Dregistry_base_url=/docs/registry/ \
--templates=/home/weaver/templates \
--target=markdown \
--future \
/home/weaver/target
ℹ No registry manifest found: /home/weaver/source/registry_manifest.yaml
Diagnostic report:
invalid_semconv_group
× The following YAML snippet does not match any of the allowed schemas
│ (anyOf, see help section).
help: Specifies the stability of the semantic convention. Note that, if
stability is missing but deprecated is present, it will automatically
set the stability to deprecated. If deprecated is present and
stability differs from deprecated, this will result in an error.
/ cc @semconv-dotnet-approver @stevejgordon @martinjt |
@lmolkova thanks for your time and feedback, appreciated. Let's move naming discussion back the other PR to where there are the rest of the stakeholders, so we don't have to duplicate the same explanations twice. I will update this PR once we reach conclusion there. I will also add more links and explanations later. |
# Conflicts: # docs/dotnet/README.md
Changes
Adding new metrics for Blazor UI framework
Related PR
dotnet/aspnetcore#61609
Merge requirement checklist
[chore]