Add SQL commenter as context propagation for databases #2495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pellared
approved these changes
Jul 8, 2025
zacharycmontoya
approved these changes
Jul 8, 2025
nenadnoveljic
approved these changes
Jul 9, 2025
4 tasks
Kielek
reviewed
Jul 9, 2025
cheempz
reviewed
Jul 9, 2025
lmolkova
reviewed
Jul 11, 2025
brettmc
reviewed
Jul 16, 2025
jsuereth
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
trask
reviewed
Jul 28, 2025
trask
reviewed
Jul 28, 2025
|
@open-telemetry/semconv-db-approvers PTAL |
trask
reviewed
Aug 4, 2025
|
@trask, I find all comments are resolved. Is that okay for you to approve this PR? |
XSAM
force-pushed
the
db-context-propagation-via-sql-commenter
branch
from
247551d to
b0372cb
Compare
|
Sorry for accidentally triggering so many reviewing groups... 🥲 |
|
@open-telemetry/specs-semconv-maintainers, all comments are resolved. Could we merge this PR? |
trask
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2162, Replace #2236. All previous commits are copied to this PR.
This PR focused solely on the SQL commenter, as #2363 has been merged.
XSAM/otelsql#512 is the prototype that demonstrates the SQL commenter with the
text attributespropagator.Changes
Add SQL commenter as context propagation for databases