Skip to content

Conversation

Cirilla-zmh
Copy link
Member

Fixes #2794

Changes

Add new enum items for the values of gen_ai.provider.name.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

component: gen-ai

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Adds `gen_ai.provider.name` attribute values: `alibaba.dashscope`, `alibaba.gen_ai`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix ci error here

stability: development
value: "aws.bedrock"
brief: '[AWS Bedrock](https://aws.amazon.com/bedrock)'
- id: alibaba.dashscope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to document the whole convention, not just the constant name? It's the best practice:

Only define new system identifiers when you also document how conventions apply
to that system. For example, when adding a new `db.system.name` value, create

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reminder! Do you mean that I should add a vendor-specific convention, such as for GCP or Azure? If so, we happen to be planning to do exactly that!

However, it might take some time. I think, for now, we can first add the enumeration, and later add the complete Alibaba-specific convention — which usually means more internal discussions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dicussion on SIG call:

Add alibaba vendor-specific conventions.

Copy link

github-actions bot commented Oct 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 8, 2025
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Alibaba into generative AI providers

3 participants