-
Notifications
You must be signed in to change notification settings - Fork 273
Adds gen_ai.provider.name attribute values: alibaba.dashscope, alibaba.gen_ai #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
component: gen-ai | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Adds `gen_ai.provider.name` attribute values: `alibaba.dashscope`, `alibaba.gen_ai`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix ci error here
stability: development | ||
value: "aws.bedrock" | ||
brief: '[AWS Bedrock](https://aws.amazon.com/bedrock)' | ||
- id: alibaba.dashscope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to document the whole convention, not just the constant name? It's the best practice:
semantic-conventions/docs/how-to-write-conventions/README.md
Lines 181 to 182 in e7eb016
Only define new system identifiers when you also document how conventions apply | |
to that system. For example, when adding a new `db.system.name` value, create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reminder! Do you mean that I should add a vendor-specific convention, such as for GCP or Azure? If so, we happen to be planning to do exactly that!
However, it might take some time. I think, for now, we can first add the enumeration, and later add the complete Alibaba-specific convention — which usually means more internal discussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dicussion on SIG call:
Add alibaba vendor-specific conventions.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #2794
Changes
Add new enum items for the values of
gen_ai.provider.name
.Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]