Skip to content

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Oct 6, 2025

Fixes #2862

Changes

Adds the network.local.* attributes to the rpc server spans just like as has been done in the http server spans.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo thompson-tomo requested review from a team as code owners October 6, 2025 03:06
@github-actions github-actions bot added enhancement New feature or request area:rpc labels Oct 6, 2025
@thompson-tomo thompson-tomo marked this pull request as draft October 6, 2025 07:31
@thompson-tomo thompson-tomo changed the title Add network.local to rpc Add network.local.* atttibutes to rpc server span Oct 6, 2025
@trask trask changed the title Add network.local.* atttibutes to rpc server span Add network.local.* attributes to rpc server span Oct 9, 2025
- ref: network.local.address
requirement_level: opt_in
- ref: network.local.port
requirement_level: opt_in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in SIG meeting, unsure whether to add these since all attributes are technically "opt-in"

Copy link
Member

@lmolkova lmolkova Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not add them until we have an ask / feedback that proves them to be useful. Adding opt-in attribute in the future is not a breaking change.

Adding them now might send a signal to instrumentation authors to put an actual effort to support them, but over the years we haven't received asks to add them to RPC server spans.

I think we had them on HTTP spans before we started stabilization process, but also they are customized (description on the address is updated to talk about multi-IP hosts), so there might be some scenario behind it there.

@thompson-tomo thompson-tomo force-pushed the feature/#2862_NetworkLocal branch from cae3e06 to d06879b Compare October 9, 2025 01:30
Co-authored-by: Trask Stalnaker <[email protected]>
@thompson-tomo thompson-tomo marked this pull request as ready for review October 9, 2025 01:31
@trask
Copy link
Member

trask commented Oct 16, 2025

Closing based on #2876 (comment)

@trask trask closed this Oct 16, 2025
@thompson-tomo thompson-tomo deleted the feature/#2862_NetworkLocal branch October 16, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:rpc enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

Add network.local.* attribute to rpc server span

3 participants