-
Notifications
You must be signed in to change notification settings - Fork 282
Deprecate per-rpc status code attributes in favor of rpc.response.status_code
#2920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmolkova
wants to merge
14
commits into
open-telemetry:main
Choose a base branch
from
lmolkova:rpc-status-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+588
−628
Open
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b41ddbf
Deprecate per-rpc status code attributes in favor of
lmolkova 8fa9e15
changelog
lmolkova 79fb1be
remove gRPC status code mapping
lmolkova 0307a6a
up
lmolkova 1e87f4a
Apply suggestions from code review
lmolkova 6174d9f
Merge branch 'main' into rpc-status-code
lmolkova 881611c
Remove error message due to sensitivity concerns https://github.com/o…
lmolkova 7a273a8
Merge branch 'main' into rpc-status-code
lmolkova 272506e
fix merge conflict
lmolkova d170362
Merge branch 'main' into rpc-status-code
lmolkova 9eeb378
update generic error.type description to use RPC instead of gRPC
lmolkova 42b2d28
refine error.type for RPC
lmolkova fc8cb41
return response for consistency
lmolkova ac3c39e
lint
lmolkova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| change_type: breaking | ||
| component: rpc | ||
| note: > | ||
| Deprecate `rpc.grpc.status_code`, `rpc.connect_rpc.error_code` and `rpc.jsonrpc.error_code` attributes | ||
| in favor of the more general `rpc.status_code` attribute. | ||
| issues: [1504, 2920] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.