Skip to content

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Oct 24, 2025

  • Re-use same macros both in registry and entity snippets.
  • Make sure identifying/descriptive attributes show up in snippets.
  • Ensure warning about identifying/descriptive attributes and stability shows up in snippets.
  • Move all attributes for an entity into a single table.

- Re-use same macros both in registry and entity snippets.
- Make sure identifying/descriptive attributes show up in snippets.
- Ensure warning about identifying/descriptive attributes and stability
  shows up in snippets.
@jsuereth jsuereth marked this pull request as ready for review October 24, 2025 16:27
@jsuereth jsuereth requested review from a team as code owners October 24, 2025 16:27
@lmolkova
Copy link
Member

WDYT about something like

Attribute Type Description Examples Requirement Level Stability
service.name Identifying string Logical name of the service. [1] shoppingcart Required Stable
service.instance.id Identifying string The string ID of the service instance. [2] 627cc493-f310-47de-96bd-71410b7dec09 Recommended Development
service.namespace Identifying string A namespace for service.name. [3] Shop Recommended Development
service.version string The version string of the service API or implementation. The format is not defined by these conventions. 2.0.0; a01dbef8a Recommended Stable

vs (in the current version)

Attribute Type Description Examples Requirement Level Stability
identity
service.name string Logical name of the service. [1] shoppingcart Required Stable
service.instance.id string The string ID of the service instance. [2] 627cc493-f310-47de-96bd-71410b7dec09 Recommended Development
service.namespace string A namespace for service.name. [3] Shop Recommended Development
description
service.version string The version string of the service API or implementation. The format is not defined by these conventions. 2.0.0; a01dbef8a Recommended Stable

it might work similar to @joaopgrassi 's proposal for sampling-relevant attrs here
#2678 (comment)

@jsuereth
Copy link
Contributor Author

@lmolkova I'd prefer to have it (a) sorted so identity is first and (b) a clear separation between identity + description. I think, going forward, it's going to be important to delineate what these mean to folks using entities.

Anyone in @open-telemetry/entities-maintainers have thoughts?

@joaopgrassi
Copy link
Member

Also I guess we want to align the columns with #2867?

@jsuereth
Copy link
Contributor Author

@lmolkova PTAL at latest incarnation of the table - it's a blend of what you did and what I did

@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Oct 27, 2025
Copy link
Contributor

@thompson-tomo thompson-tomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments to tackle repeated empty lines.

Also is it still the plan to remove the resource pages as per #2327

@jsuereth
Copy link
Contributor Author

Also is it still the plan to remove the resource pages as per #2327

Yes, with the caveat - there's a lot more urgent things to sort out first.

@joaopgrassi
Copy link
Member

I liked the badges 😞. Hopefully we can find a long-term solution with the html limitation with the OTel website. CC @chalin we cannot use html inside markdown tables, right?

@chalin
Copy link
Contributor

chalin commented Oct 30, 2025

@joaopgrassi - OTel.io isn't the limitation. Here's my take on all this. IMHO:

  • The tables are complicated enough already. Adding raw HTML is just going to make editing them more of a challenge.

  • I see this repo as the raw source of the semconv -- that's why pages are written in Markdown rather than a markup language or Rich Text Format. We should avoid stylistic embellishments and focus on semantics/content.

  • Previewing markdown pages via GH is a convenience. As you know GH preview has limitations that are by design: you can't use custom styling, nor redirects, etc. In order to use features such as styles, etc., GH recommends using GH Pages or, like we do, other tools such as Hugo.

We can fix the badge styling in OTel.io using CSS. (We could even implement an auto-rendering of badges for certain (solo) keywords like "Stable" and "Development" that might appear in tables (maybe via a special marker !Stable))

Thoughts?

As I looked at the semconv pages on OTel.io, I just noticed that badges aren't rendering properly. I'll create an issue for that.

/cc @open-telemetry/docs-maintainers

@chalin
Copy link
Contributor

chalin commented Oct 30, 2025

@jsuereth wrote:

Do you remember why we needed to avoid HTML tags in our markdown for opentelemetry.io?

You can have HTML inside a Markdown table cell.

Maybe you are remembering #2536? The problem there was that links inside HTML-encoded tables weren't getting processed correctly.

@chalin
Copy link
Contributor

chalin commented Oct 30, 2025

Let me know if you want me to look into the badge-size issue. FYI, I'll be fixing the current bug with badge display via:

@jsuereth
Copy link
Contributor Author

@chalin AH yes, I think you're right. I couldn't emember the details and wanted to avoid breaking opentelemetry.io. Thanks for the links, so images are ok, but that gets into your other comment.

I absolutely agree with what you're saying - github pages are a convenience and we need rich markup going forward. If you think this is fixable on opentelemetry.io I'm happy to defer to that. I agree these tables are already too complicated.

@jsuereth jsuereth moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Oct 30, 2025
@jsuereth jsuereth enabled auto-merge October 30, 2025 18:44
@jsuereth jsuereth added this pull request to the merge queue Oct 30, 2025
Merged via the queue into open-telemetry:main with commit 8d9a665 Oct 30, 2025
15 checks passed
@jsuereth jsuereth deleted the chore-cleanup-entity-snippet branch October 30, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants