Add in code attributes to exception event #1981 #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
Contributor
Author
|
@joaopgrassi can this be reopened. The issue has been accepted but pr still got closed. |
pellared
approved these changes
Nov 7, 2025
trask
reviewed
Nov 16, 2025
Comment on lines
+17
to
+24
| - ref: code.function.name | ||
| requirement_level: opt_in | ||
| - ref: code.file.path | ||
| requirement_level: opt_in | ||
| - ref: code.line.number | ||
| requirement_level: opt_in | ||
| - ref: code.column.number | ||
| requirement_level: opt_in |
Member
There was a problem hiding this comment.
will this be the code where the exception was originally thrown? or the user code where it was captured?
cc @open-telemetry/browser-approvers since related to #1942
Contributor
Author
There was a problem hiding this comment.
My preference would be the code which threw the exception if the language provides it.
thompson-tomo
force-pushed
the
feature/#1981_AddCodeToExceptions
branch
from
3d891aa to
1fd9c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1981
Changes
Adds in the code attributes to the exception event as opt-in
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]