Add Browser Resource Timing Event #3069
Conversation
|
@martinkuba updated url.full to be part of body field and updated description, related to |
|
Open questions are related to having query string separately, let me know your thoughts @joaquin-diaz @overbalance @trask |
There was a problem hiding this comment.
We need to consider the outcome of #2827 (comment) and ensure that what is done for resources is consistent with http etc.
Ie do we just use the http span or do we need a new file.download.client span? I suspect we might need to stick to the http span if it is too difficult for instrumentation to determine which span definition needs to be used.
docs/browser/events.md
Outdated
| | `responseEnd` |  | `Recommended` | double | The [time](https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp) immediately after the browser receives the last byte of the resource or immediately before the transport connection is closed, whichever comes first, in milliseconds. See [responseEnd](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseEnd). | `510.6000000014906` | | ||
| | `responseStart` |  | `Recommended` | double | The [time](https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp) immediately after the browser receives the first byte of the response from the server, cache, or local resource, in milliseconds. See [responseStart](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStart). | `508.6000000014901` | | ||
| | `secureConnectionStart` |  | `Recommended` | double | The [time](https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp) immediately before the browser starts the handshake process to secure the current connection, in milliseconds. See [secureConnectionStart](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/secureConnectionStart). | `476.6000000014903` | | ||
| | `url` |  | `Required` | string | The full URL of the resource being fetched. [1] | `https://www.example.com/path`; `//localhost` | |
There was a problem hiding this comment.
Why don't we make this file.path and have it as an attribute? If we don't create a dedicated span
There was a problem hiding this comment.
Not all resources are files. ResourceTiming also applies to fetch, xhr, and beacon.
There was a problem hiding this comment.
For fetch/xhr/Beacon why aren't we using the standard http client span? We can use the pr linked in my other comment to handle capturing the timing details.
github-project-automation
bot
moved this from Untriaged
to Blocked
in Semantic Conventions Triage
trask
moved this from Blocked
to Awaiting codeowners approval
in Semantic Conventions Triage
4 participants
This is to continue discussion in original PR #1943, thanks @Karlie-777 for your efforts, I will try to add comments for open questions/issues here.
Changes
Adds Browser Resource Timing events to the Semantic Conventions
Merge requirement checklist
[chore]