Skip to content

Conversation

@vitorvasc
Copy link
Member

@vitorvasc vitorvasc commented Nov 27, 2025

Fixes #3138. Also referenced by open-telemetry/opentelemetry.io#8311.

Changes

You can test the updates and the redirect rules here: https://deploy-preview-8311--opentelemetry.netlify.app.

When navigating to: https://deploy-preview-8311--opentelemetry.netlify.app/docs/specs/semconv/database/, it now correctly redirects to the new path: https://deploy-preview-8311--opentelemetry.netlify.app/docs/specs/semconv/db/.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @vitorvasc!

Did you try adding the redirects rule to the db/README.md?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM / is functional as is. I'd prefer having the db redirects more tightly scoped if that'll work. (Approving now in case I can't get back to it later.)

@vitorvasc
Copy link
Member Author

@chalin I did try at first, but I didn't really test it integrating with open-telemetry/opentelemetry.io#8311. I was trying to test everything locally, but none of the redirect rules were working correctly (I'll follow-up about that in the #otel-comms-approvers thread we've been discussing it).

My thinking was that if we added the rule to docs/db/README.md, the redirect would end up being /docs/specs/semconv/db/database/ -> /docs/specs/semconv/db/. In any case, I'll try pushing a few more commits to validate that behavior, I'm not totally sure that's how it actually works.

@chalin
Copy link
Contributor

chalin commented Nov 27, 2025

@vitorvasc

@chalin I did try at first, but I didn't really test it integrating with open-telemetry/opentelemetry.io#8311. I was trying to test everything locally, but none of the redirect rules were working correctly (I'll follow-up about that in the #otel-comms-approvers thread we've been discussing it).

👍🏻 Yeah, Netlify CLI doesn't always play nice when run locally.

My thinking was that if we added the rule to docs/db/README.md, the redirect would end up being /docs/specs/semconv/db/database/ -> /docs/specs/semconv/db/. In any case, I'll try pushing a few more commits to validate that behavior, I'm not totally sure that's how it actually works.

The rules have special-case handling to avoid that. Either you'll need to use from: database/* or from: ./database/* I can't recall which :)

@vitorvasc vitorvasc force-pushed the db_drop-aliases-add-wildcard-redirect-rule branch from 39a3859 to 60f849e Compare November 27, 2025 11:44
@chalin
Copy link
Contributor

chalin commented Nov 27, 2025

@vitorvasc - even if you can't test using Netlify CLI, you can always inspect the redirects file that gets generated.

@vitorvasc
Copy link
Member Author

@vitorvasc - even if you can't test using Netlify CLI, you can always inspect the redirects file that gets generated.

💡 💡 !

Okay, just tested it by checking the generated _redirect file, and looks well. I've pushed another commit to have the rule more scoped. Thanks! 😄

Co-authored-by: Patrice Chalin <[email protected]>
vitorvasc and others added 2 commits November 27, 2025 09:06
Co-authored-by: Patrice Chalin <[email protected]>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @vitorvasc for trying out the alternatives.
LGTM

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

[editorial] Drop aliases from 3108 and add a wildcard redirect rule

4 participants