Stabilize deployment environment#3339
Stabilize deployment environment#3339Arnav-Bansal wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
4fdfcee to
ee88c25
Compare
|
This needs a changelog and rebase |
lmolkova
left a comment
There was a problem hiding this comment.
We need to specify the role of attributes on the entity - see https://github.com/open-telemetry/semantic-conventions/pull/3339/changes#r2743336364
|
The key thing which was missed is that the actual stability of the entity wasn't updated but rather just the stability in the doc was changed. This is why the policy passed. |
| The software deployment. | ||
| attributes: | ||
| - ref: deployment.environment.name | ||
| role: descriptive |
There was a problem hiding this comment.
Should it be descriptive? As a result deployment entity does not have any identity attributes.
/cc @open-telemetry/semconv-service-and-deployment-approvers
There was a problem hiding this comment.
Done. Added deployment.name as idenitify attribute as well.
| type: entity | ||
| stability: development | ||
| stability: stable | ||
| name: deployment |
There was a problem hiding this comment.
Also, is this right that this entity is called deployment and not deployment.environment?
If it's deployment, should it contain any other existing deployment attrs such as deployment.name | id
There was a problem hiding this comment.
Agree it makes more sense to me to have deployment & deployment.environment entities.
There was a problem hiding this comment.
Updated the file to make it more apt.
joaopgrassi
left a comment
There was a problem hiding this comment.
We can't stabilize this, until we have decided on how to deal with the values of it: #2910.
f423ef2 to
cf3dd20
Compare
Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
cf3dd20 to
1b4525d
Compare
Changes
This PR introduce changes to stabilize the deployment.environment.name field.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]