Skip to content

Stabilize deployment environment#3339

Open
Arnav-Bansal wants to merge 7 commits intoopen-telemetry:mainfrom
Arnav-Bansal:stabilize-deployment-environment
Open

Stabilize deployment environment#3339
Arnav-Bansal wants to merge 7 commits intoopen-telemetry:mainfrom
Arnav-Bansal:stabilize-deployment-environment

Conversation

@Arnav-Bansal
Copy link
Contributor

@Arnav-Bansal Arnav-Bansal commented Jan 27, 2026

Changes

This PR introduce changes to stabilize the deployment.environment.name field.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@Arnav-Bansal Arnav-Bansal force-pushed the stabilize-deployment-environment branch from 4fdfcee to ee88c25 Compare January 27, 2026 10:20
@github-actions github-actions bot added enhancement New feature or request area:deployment labels Jan 27, 2026
@Arnav-Bansal Arnav-Bansal marked this pull request as ready for review January 29, 2026 07:43
@Arnav-Bansal Arnav-Bansal requested review from a team as code owners January 29, 2026 07:43
@jsuereth
Copy link
Contributor

This needs a changelog and rebase

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to specify the role of attributes on the entity - see https://github.com/open-telemetry/semantic-conventions/pull/3339/changes#r2743336364

@thompson-tomo
Copy link
Contributor

The key thing which was missed is that the actual stability of the entity wasn't updated but rather just the stability in the doc was changed. This is why the policy passed.

pellared
pellared previously approved these changes Jan 30, 2026
@pellared pellared dismissed their stale review January 30, 2026 12:36

approved by mistake

The software deployment.
attributes:
- ref: deployment.environment.name
role: descriptive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be descriptive? As a result deployment entity does not have any identity attributes.

/cc @open-telemetry/semconv-service-and-deployment-approvers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added deployment.name as idenitify attribute as well.

type: entity
stability: development
stability: stable
name: deployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is this right that this entity is called deployment and not deployment.environment?

If it's deployment, should it contain any other existing deployment attrs such as deployment.name | id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it makes more sense to me to have deployment & deployment.environment entities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the file to make it more apt.

Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't stabilize this, until we have decided on how to deal with the values of it: #2910.

@Arnav-Bansal Arnav-Bansal force-pushed the stabilize-deployment-environment branch from cf3dd20 to 1b4525d Compare February 5, 2026 18:24
@lmolkova lmolkova moved this from Blocked to Awaiting codeowners approval in Semantic Conventions Triage Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:deployment enhancement New feature or request

Projects

Status: Awaiting codeowners approval

Development

Successfully merging this pull request may close these issues.

9 participants