Define declarative configuration path for sensitive_query_parameters#3403
Open
trask wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Define declarative configuration path for sensitive_query_parameters#3403trask wants to merge 1 commit intoopen-telemetry:mainfrom
sensitive_query_parameters#3403trask wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
sensitive-query-parameters
branch
from
f82e10a to
1de903d
Compare
trask
force-pushed
the
sensitive-query-parameters
branch
from
1de903d to
89bf0d9
Compare
lmolkova
reviewed
Feb 5, 2026
|  | ||
| HTTP instrumentation MAY provide a way to override this list via declarative configuration. | ||
| If so, it SHOULD use the `sensitive_query_parameters` property | ||
| (an array of strings with minimum items 0) under `.instrumentation/development.general.http`. |
Member
There was a problem hiding this comment.
there are other instrumentation that may populate url.full or url.query (e.g. elasticsearch does) - do we expect each of these instrumentations to define the section?
Alternative:
general:
sanitization:
url:
sensitive_query_parameters: []
enduser: # imaginary future
id_obfuscation_algo:There will also be more sanitization options, it kind of makes sense to group them together under sanitization section and then by attribute key/namespace rather than by instrumentation.
It does not affect HTTP headers or methods much because they are HTTP-specific anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
This property doesn't have any precedent for naming, so would be worth considering other options besides
sensitive_query_parameters.cc @open-telemetry/configuration-approvers