-
Notifications
You must be signed in to change notification settings - Fork 282
Added url.template to HTTP client attributes #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmolkova
merged 26 commits into
open-telemetry:main
from
klauco:allow-http-route-on-client
May 7, 2024
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fecc7ea
Added http route attribute to HTTP client attributes
klauco ac532b6
make table-generation
trask f3584ff
fixed comments
klauco 148b46e
Updated brief
klauco 0dd5aab
run table generation
klauco 02ee3c2
changelog entry
klauco 4c184a8
maybe -> may be
klauco d5c3a53
absolute path reference used, http spans with opt-in http.route
klauco 8cbb7d2
using url.template on client spans and metrics
klauco 384a230
updated brief
klauco d7f5183
Apply suggestions from code review
klauco 4586315
marking semantic conventions for spans as stable unless otherwise spe…
klauco 21c3d9d
toc updated
klauco 14f1612
rebase and suggest span name
13cf2ea
clean up
7ec0443
change metrics to emphasize experimental status of url.template
17e7366
lint fix
klauco 36913ad
Merge branch 'main' into allow-http-route-on-client
klauco 2e18b03
Core review
03a5e66
span kind specification
klauco ed69c63
Merge branch 'main' into allow-http-route-on-client
klauco e76a144
Update docs/http/http-spans.md
549e633
Merge branch 'main' into allow-http-route-on-client
klauco b040abe
Merge branch 'main' into allow-http-route-on-client
klauco 4f9deb9
Merge branch 'main' into allow-http-route-on-client
klauco 540237d
Merge branch 'main' into allow-http-route-on-client
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: http | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: New `url.template` attribute added to URL, HTTP client attributes are extended with optional low-cardinality `url.template` | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [675] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.