Skip to content

Conversation

@CommCody
Copy link

@CommCody CommCody commented Nov 7, 2025

Summary

The weaver registry check command expects an EntityAssociation to be a string. But the schema defines it as an array.

groups:
  - id: span.example.works_for_schema
    type: span
    span_kind: internal
    stability: development
    brief: Example working for the schema
    entity_associations:
      - [ 'entity.example']
  - id: span.example.works_for_tooling
    type: span
    span_kind: internal
    stability: development
    brief: Example working for the tooling
    entity_associations:
      - 'entity.example'

An example from the semantic-conventions repo can be found here: https://github.com/open-telemetry/semantic-conventions/blob/65f5c612261508f55800ab622a989349f29ba5ef/model/k8s/metrics.yaml#L29

The proposed change also aligns with the v2 schema

Changes

  • Change the schema so it aligns with the tooling and existing definitions in the semantic-conventions repo

@CommCody CommCody requested a review from a team as a code owner November 7, 2025 15:21
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CommCody / name: Joris Goovaerts (4f5b8cb)

@jsuereth
Copy link
Contributor

can you update the description to be accurate?

Also @lmolkova can you review this? I don't use the schema outside of error messages inside weaver, and It's not clear to me if this is a fix or a breakage.

@CommCody
Copy link
Author

can you update the description to be accurate?

Fixed, apologies for the copy-paste issue

weaver check expects an EntityAssociation to be a string,
but the schema says it should be an array.
@CommCody
Copy link
Author

Hi @jsuereth and @lmolkova

Is there anything I can do to help move this small change along?

Kind Regards,
Joris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants