Skip to content

Conversation

@jerbly
Copy link
Contributor

@jerbly jerbly commented Jan 5, 2026

weaver-mcp

This PR adds weaver registry mcp an MCP (Model Context Protocol) server that exposes the semantic conventions registry to LLMs. This enables natural language queries for finding and understanding conventions while writing instrumentation code.

Tool Description
search Search across all registry items (attributes, metrics, spans, events, entities)
get_attribute Get detailed information about a specific attribute by key
get_metric Get detailed information about a specific metric by name
get_span Get detailed information about a specific span by type
get_event Get detailed information about a specific event by name
get_entity Get detailed information about a specific entity by type
live_check Validate telemetry samples against the registry

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 87.58621% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.4%. Comparing base (20f8d96) to head (422ffa3).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_mcp/src/lib.rs 11.1% 16 Missing ⚠️
crates/weaver_mcp/src/service.rs 97.5% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1113     +/-   ##
=======================================
+ Coverage   79.1%   80.4%   +1.2%     
=======================================
  Files        102     104      +2     
  Lines       7943    8229    +286     
=======================================
+ Hits        6284    6617    +333     
+ Misses      1659    1612     -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerbly jerbly marked this pull request as ready for review January 5, 2026 02:41
@jerbly jerbly requested a review from a team as a code owner January 5, 2026 02:41
/// - `get_entity` - Get a specific entity by type
/// - `live_check` - Validate telemetry samples against the registry
#[derive(Clone)]
pub struct WeaverMcpService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this may be crazy, but is there any chance we can re-use the vanilla API server and just "wrap" API methods with MCP definitions instead of having two instances of serving / application flow?

I think there's a LOT of commonality between the two pieces, and it'd be ideal if we could share it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants