Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Nov 24, 2024

Sorry Javadoc is weird.

See open-telemetry/semantic-conventions-java#100 for more details.

@trask trask marked this pull request as ready for review November 24, 2024 19:34
@trask trask requested a review from a team as a code owner November 24, 2024 19:34
@codecov
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (aeae196) to head (0ced42b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #474     +/-   ##
=======================================
- Coverage   73.9%   73.9%   -0.1%     
=======================================
  Files         50      50             
  Lines       3901    3903      +2     
=======================================
+ Hits        2885    2886      +1     
- Misses      1016    1017      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@lquerel Are you aware of any other language this may impact negatively?

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks

@lquerel lquerel merged commit 772da65 into open-telemetry:main Nov 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants