fix: allow loading registries and policies from hidden directories #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary is_hidden() filter that prevented loading from directories starting with '.' (dot). The existing file type filters (is_semantic_convention_file and is_policy_file) are sufficient to exclude problematic paths. Fixes open-telemetry#958 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replaced manual Default implementation with derived Default trait and #[default] attribute to fix clippy::derivable_impls warning. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
- Coverage 78.3% 78.3% -0.1%
=======================================
Files 77 77
Lines 6122 6114 -8
=======================================
- Hits 4799 4789 -10
- Misses 1323 1325 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lquerel
requested changes
Nov 3, 2025
Contributor
lquerel
left a comment
lquerel
left a comment
There was a problem hiding this comment.
I'd prefer an opt-in parameter (e.g. --include-hidden) that allows exploring hidden files/directories, to avoid surprising other users who would not find it normal for a CLI to inspect files in locations such as .git, .svn, .idea, .vscode, .cache, .local, .venv, .aws/credentials, .kube/config, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary
is_hidden()filter that prevented loading from directories starting with.(dot). The existing file type filters are sufficient to exclude problematic paths.Changes
is_hidden()function and filter fromweaver_resolver/src/lib.rs(registry loading)is_hidden()function and filter fromweaver_checker/src/lib.rs(policy loading)Test plan
test_hidden_directorythat verifies loading from.hidden_reg/directoryFixes #958
🤖 Generated with Claude Code