Open
Conversation
securityContext.privileged = true gives unnecessary permissions to containers. Only use required capabilities with securityContext.Capabilities option use different security contexts for them otg-gnmi-server and keng-controller since they don't need as many capabilities as TE and PE
hashwini-keysight
approved these changes
Feb 1, 2024
Collaborator
|
Without explicitly assigning some security cap to controller & gnmi, the node mapped port is not accepting requests. It will need some capability to be assigned. I will investigate further, update this PR and then merge. |
Author
would need |
Collaborator
|
The node ports are > 30000. I think we may have to add some explicit, minimal capability. I will investigate later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
securityContext.privileged = true gives unnecessary permissions to containers.
Only use required capabilities with securityContext.Capabilities option
use different security contexts for them otg-gnmi-server and keng-controller since they don't need as many capabilities as TE and PE