Skip to content

Dev multi port traffic #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anjan-keysight wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Dev multi port traffic #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
80a34f5
Support for multiple traffic Rx ports
anjan-keysight May 12, 2023
28a7f4a
Update auto generated content
actions-user May 12, 2023
8a20dc6
Added rx ports array field description
anjan-keysight May 12, 2023
41bb8de
Merge branch 'dev-multi-port-traffic' of https://github.com/open-traf…
anjan-keysight May 12, 2023
4f8f325
Update auto generated content
actions-user May 12, 2023
012d6e2
Minor indentation update
anjan-keysight May 15, 2023
cd7c728
Update auto generated content
actions-user May 15, 2023
446db75
Keep port rx_name in deprecated state
anjan-keysight May 18, 2023
57440d0
Update auto generated content
actions-user May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions artifacts/openapi.html
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 21 additions & 0 deletions artifacts/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions artifacts/otg.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 16 additions & 1 deletion flow/endpoint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,27 @@ components:
rx_name:
description: |-
The unique name of a port that is the intended receive port.
x-status:
status: deprecated
information: |-
This property is deprecated in favor of property rx_names
type: string
x-constraint:
- '/components/schemas/Port/properties/name'
- '/components/schemas/Lag/properties/name'

x-field-uid: 2
rx_names:
Copy link
Contributor

@ajbalogh ajbalogh May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks backward compatibility for all port based tests.
Some options to mitigate broken tests would be:

  • deprecate the rx_name property for a few releases and at the same time introduce rx_names
  • introduce a new choice called ports which will have rx_names

Copy link
Contributor Author

@anjan-keysight anjan-keysight May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will keep the rx_name property in deprecated state for few releases.

Copy link
Contributor Author

@anjan-keysight anjan-keysight May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajbalogh I have updated and retained rx_name property in deprecated state.

description: |-
Unique names of ports that are intended receive ports.
type: array
items:
description: |-
The unique name of a port that is the intended receive port.
type: string
x-constraint:
- '/components/schemas/Port/properties/name'
- '/components/schemas/Lag/properties/name'
x-field-uid: 3
Flow.Router:
description: >-
A container for declaring a map of 1..n transmit devices
Expand Down