bailian_sdk: remove bundled cJSON, use system library instead#2
Closed
yanxingyu17 wants to merge 1 commit intoopen-vela:devfrom
Closed
bailian_sdk: remove bundled cJSON, use system library instead#2yanxingyu17 wants to merge 1 commit intoopen-vela:devfrom
yanxingyu17 wants to merge 1 commit intoopen-vela:devfrom
Conversation
Remove third_party/cJSON/ directory as the bailian demo application now uses the system cJSON library (apps/netutils/cjson) instead. Note: third_party/tinycrypt is retained because the SDK's pre-built static libraries were compiled against its bundled tinycrypt version. Replacing it with the system tinycrypt causes silent encryption failures, resulting in audio data not being sent to the server. Signed-off-by: v-yanxingyu <v-yanxingyu@xiaomi.com>
Collaborator
Author
|
Closing: SDK should remain unchanged as released by Alibaba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
third_party/cJSON/directory (header + static library)apps/netutils/cjson) insteadNote:
third_party/tinycrypt/is retained because the SDK's pre-built static libraries were compiled against its bundled tinycrypt version. Replacing it with the system tinycrypt causes silent encryption failures, resulting in audio data not being sent to the server (server returnsClientAudioTimeout). Since the SDK is closed-source pre-built, we cannot modify its internal dependencies.Impact
Testing
./build.sh vendor/openvela/boards/vela/configs/goldfish-armeabi-v7a-ap --cmakeSigned-off-by: v-yanxingyu v-yanxingyu@xiaomi.com