delete device_lock in ag #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: v/81564 rootcause: In ag_service, all locks are called by a single thread called bluetoothd, and there are no race conditions, so locks can be optimized. Signed-off-by: wuxiaodong6 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR removes the device_lock mutex from the HFP AG service, simplifying the code based on the single-threaded execution model where all operations are serialized through the service loop.
Key changes:
- Removed
pthread_mutex_t device_lockfrom theag_service_tstructure - Eliminated all lock/unlock operations protecting device list access
- Removed mutex initialization and destruction code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/81564
rootcause: In ag_service, all locks are called by a single thread called bluetoothd, and there are no race conditions, so locks can be optimized.