Android test suit update #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzh-terry
reviewed
Dec 23, 2025
gzh-terry
reviewed
Dec 23, 2025
Contributor
gzh-terry
left a comment
gzh-terry
left a comment
There was a problem hiding this comment.
Update the reasons for each commit.
chengkai15
previously approved these changes
Dec 23, 2025
chejinxian
approved these changes
Dec 24, 2025
expliyh
force-pushed
the
ts-a-comp
branch
2 times, most recently
from
72722c2 to
cb33069
Compare
gzh-terry
reviewed
Dec 25, 2025
| // Unregister Server #1 | ||
| Button buttonUnregister_1 = findViewById(R.id.button_spp_server_unregister_1); | ||
| buttonUnregister_1.setOnClickListener(new View.OnClickListener() { | ||
| @RequiresPermission(Manifest.permission.BLUETOOTH_ADVERTISE) |
Contributor
There was a problem hiding this comment.
Why it requires BLUETOOTH_CONNECT on register, but requires BLUETOOTH_ADVERTISE on unregister?
Contributor
Author
There was a problem hiding this comment.
Inherits from btSock_1.unregister();
gzh-terry
reviewed
Dec 25, 2025
| } | ||
|
|
||
| private final ScanCallback scanCallback = new ScanCallback() { | ||
| @RequiresPermission(Manifest.permission.BLUETOOTH_CONNECT) |
Contributor
There was a problem hiding this comment.
Should this be a BLUETOOTH_SCAN?
Contributor
Author
There was a problem hiding this comment.
Inherits from result.getDevice().getName();
gzh-terry
reviewed
Dec 25, 2025
| private EditText etFilter; | ||
| private BredrInquiryAdapter bredrInquiryAdapter; | ||
|
|
||
| @RequiresPermission(Manifest.permission.BLUETOOTH_SCAN) |
Contributor
There was a problem hiding this comment.
Does "Inquiry" belongs to BLUETOOTH_SCAN?
Contributor
Author
There was a problem hiding this comment.
Inherits from initView();
gzh-terry
approved these changes
Dec 25, 2025
bug: v/81613 Update dependency versions to support compose Signed-off-by: YuhengLi <[email protected]>
bug: v/81613 Based on the file structure, the correct namespace should be com.openvela.bluetooth. Signed-off-by: YuhengLi <[email protected]>
bug: v/81613 Rootcause: necessaryBluetoothPermissioins was misspelled as necessaryBluetoothPermissions. Signed-off-by: Yuheng Li <[email protected]>
bug: v/81613 Add Kotlin support to improve development speed. Signed-off-by: Yuheng Li <[email protected]>
bug: v/81613 Add Compose support to speed up future feature development and reduce the error rate. Signed-off-by: Yuheng Li <[email protected]>
bug: v/81613 some dependency versions not match required Signed-off-by: Yuheng Li <[email protected]>
bug: v/81613 some permissions not checked before use Signed-off-by: Yuheng Li <[email protected]>
expliyh
requested review from
huangyulong3,
zhangyuan376 and
zhongzhijie1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android test suit update