Add PA sync service #352

gzh-terry · 2025-12-29T04:22:27Z

No description provided.

huangyulong3

LGTM

huangyulong3

LGTM

huangyulong3

LGTM

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 13 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CMakeLists.txt

tools/auracast_sink.c

Copilot · 2026-01-06T14:24:32Z

framework/common/advertiser_data_helper.c

+        strlcpy(info->name, (char*)data->data, MIN(sizeof(info->name), data->len));
+        break;
+
+#ifdef CONFIG_BLUETOOTH_AURACAST_SINK
+    case BT_AD_BROADCAST_NAME:
+        strlcpy(info->broadcast_name, (char*)data->data,
+            MIN(sizeof(info->broadcast_name), data->len));


The strlcpy function call specifies a maximum copy length using MIN(sizeof(info->name), data->len). However, data->len includes the AD Type byte (1 octet), which should not be counted in the data length for the name. This means an extra byte from the next AD entry could be copied into the name buffer. The correct length should be data->len - 1 to account for the AD Type byte that has already been excluded from data->data.

Suggested change

strlcpy(info->name, (char*)data->data, MIN(sizeof(info->name), data->len));

break;

#ifdef CONFIG_BLUETOOTH_AURACAST_SINK

case BT_AD_BROADCAST_NAME:

strlcpy(info->broadcast_name, (char*)data->data,

MIN(sizeof(info->broadcast_name), data->len));

strlcpy(info->name, (char*)data->data, MIN(sizeof(info->name), data->len - 1));

break;

#ifdef CONFIG_BLUETOOTH_AURACAST_SINK

case BT_AD_BROADCAST_NAME:

strlcpy(info->broadcast_name, (char*)data->data,

MIN(sizeof(info->broadcast_name), data->len - 1));

The ADV data is a string but without an ending '\0'.

Therefore we need the length data->len, which is exactly the length of the string, plus a space for '\0'.

tools/utils.h

tools/auracast_sink.c

Copilot · 2026-01-06T14:24:34Z

framework/common/advertiser_data_helper.c

+#ifdef CONFIG_BLUETOOTH_AURACAST_SINK
+    case BT_AD_BROADCAST_NAME:
+        strlcpy(info->broadcast_name, (char*)data->data,
+            MIN(sizeof(info->broadcast_name), data->len));


The strlcpy function call specifies a maximum copy length using MIN(sizeof(info->broadcast_name), data->len). However, data->len includes the AD Type byte (1 octet), which should not be counted in the data length for the broadcast name. This means an extra byte from the next AD entry could be copied into the broadcast_name buffer. The correct length should be data->len - 1 to account for the AD Type byte that has already been excluded from data->data.

Suggested change

MIN(sizeof(info->broadcast_name), data->len));

MIN(sizeof(info->broadcast_name), data->len > 0 ? data->len - 1 : 0));

data->len does not include the ending '\0', so we do need the orignal data to get the full string.

Copilot · 2026-01-06T14:24:34Z

framework/include/bt_le_scan.h

 typedef struct {
    bt_address_t addr;
+    int8_t rssi; /* RSSI in dBm (-127, +20). 0x7F if unavailable */
+    int8_t tx_power; /* transmit power of the advertiser in dBm (-127, +20). 0x7F if unavailable */
    uint8_t dev_type; /* bt_device_type_t */
-    int8_t rssi;
    uint8_t addr_type; /* ble_addr_type_t */
    uint8_t adv_type; /* ble_adv_type_t */
-    uint8_t length;
-    uint8_t pad[1];
+    uint8_t length; /* length of `adv_data` */
+    uint16_t interval; /* periodic advertising interval in 1.25 microseconds, 0 if not presented */
+    uint8_t sid; /* advertising set identifier, valid from 0x00 to 0x0F, 0xFF if not provided */
+    uint8_t flags; /* e.g., `SCAN_RESULT_FLAG_PERIODIC_ADVERTISING` */
    uint8_t adv_data[1];
 } ble_scan_result_t;


The ble_scan_result_t structure has been extended with new fields (tx_power, interval, sid, flags), but the binder parcel serialization/deserialization functions in service/ipc/binder/parcel/parcel.c have not been updated to handle these fields. The AParcel_writeBleScanResult function at lines ~577-609 and AParcel_readBleScanResult at lines ~611-653 only serialize/deserialize the old fields. This will cause data loss and potential compatibility issues for binder-based IPC.

framework/include/bt_le_scan.h

bug: v/82275 The event definition is necessary before the callbacks from periodic advertising sync. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82275 This patch defines the APIs required to synchronize a periodic advertising train. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82275 This patch includes the documentation of SAL APIs. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 A initial version that has nothing implemented. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 A initial version that starts compiling the files. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Init and uninit for PA sync. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Periodic advertising often comes from extended scanning, so we add an parser here. An alternative is Periodic Advertising Sync Transfer (to be implemented later). Signed-off-by: Zihao Gao <[email protected]>

bug: v/82380 Initial version of Auracast sink test tool Signed-off-by: Zihao Gao <[email protected]>

bug: v/82380 Add scan command to search active Auracast sources. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Parse the scan result at the client side, so we can reduce the uplink data. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82275 Add TxPower, Periodic Advertising Interval, and correct the conversion of adv_type. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Parse scan result at bttol to check if there is an Auracast source available. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Skip logs that are not available. Add more debug logs on error. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82379 Allow to stop scanning for periodic advertisers. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82820 Add an extra flag to indicate whether periodic advertising is present in the scan result. Signed-off-by: Zihao Gao <[email protected]>

bug: v/82820 Modify message codes so its safe when client and server have different version of codes. Signed-off-by: Zihao Gao <[email protected]>

gzh-terry requested a review from hyson710 as a code owner December 29, 2025 04:22

gzh-terry requested review from chengkai15 and huangyulong3 December 29, 2025 04:22

gzh-terry force-pushed the pa_sync branch from 3a36dc2 to b72dddb Compare December 29, 2025 04:24

gzh-terry requested review from liuX10 and zhangyuan376 December 29, 2025 04:28

gzh-terry force-pushed the pa_sync branch 19 times, most recently from 63d8e82 to d11efce Compare December 30, 2025 13:14

gzh-terry requested a review from zhongzhijie1 December 30, 2025 13:25

gzh-terry force-pushed the pa_sync branch from d11efce to ea8bb91 Compare December 30, 2025 15:41

huangyulong3 approved these changes Dec 31, 2025

View reviewed changes

zhongzhijie1 requested a review from Copilot January 6, 2026 14:12

Copilot started reviewing on behalf of zhongzhijie1 January 6, 2026 14:12 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

PA sync: add event definitions.

121d22a

bug: v/82275 The event definition is necessary before the callbacks from periodic advertising sync. Signed-off-by: Zihao Gao <[email protected]>

gzh-terry dismissed chengkai15’s stale review via 04b5ed2 January 6, 2026 14:36

gzh-terry force-pushed the pa_sync branch from f6b24ee to 04b5ed2 Compare January 6, 2026 14:36

zhongzhijie1 previously approved these changes Jan 6, 2026

View reviewed changes

gzh-terry dismissed zhongzhijie1’s stale review via e7905ee January 7, 2026 03:20

gzh-terry force-pushed the pa_sync branch 2 times, most recently from e7905ee to 4f65d20 Compare January 7, 2026 03:48

zhongzhijie1 previously approved these changes Jan 7, 2026

View reviewed changes

chengkai15 previously approved these changes Jan 8, 2026

View reviewed changes

gzh-terry added 15 commits January 9, 2026 17:22

SAL: add definitions for PA sync API.

809afcf

bug: v/82275 This patch defines the APIs required to synchronize a periodic advertising train. Signed-off-by: Zihao Gao <[email protected]>

SAL: add descriptions for PA sync APIs.

6b70a80

bug: v/82275 This patch includes the documentation of SAL APIs. Signed-off-by: Zihao Gao <[email protected]>

PA sync: add empty service

4a30d68

bug: v/82379 A initial version that has nothing implemented. Signed-off-by: Zihao Gao <[email protected]>

PA sync: add Kconfig

c95da27

bug: v/82379 A initial version that starts compiling the files. Signed-off-by: Zihao Gao <[email protected]>

PA sync: init and uninit for PA sync.

f41d3bb

bug: v/82379 Init and uninit for PA sync. Signed-off-by: Zihao Gao <[email protected]>

PA sync: API for parsing advertising report

9124539

bug: v/82379 Periodic advertising often comes from extended scanning, so we add an parser here. An alternative is Periodic Advertising Sync Transfer (to be implemented later). Signed-off-by: Zihao Gao <[email protected]>

Auracast sink: Add bttool for Auracast sink

ffd1d71

bug: v/82380 Initial version of Auracast sink test tool Signed-off-by: Zihao Gao <[email protected]>

Auracast sink: allow to start extended scan

43dce33

bug: v/82380 Add scan command to search active Auracast sources. Signed-off-by: Zihao Gao <[email protected]>

PA sync: allow to parse scan result

5f7f759

bug: v/82379 Parse the scan result at the client side, so we can reduce the uplink data. Signed-off-by: Zihao Gao <[email protected]>

PA sync: allow to parse scan result at SAL

6dd6be5

bug: v/82275 Add TxPower, Periodic Advertising Interval, and correct the conversion of adv_type. Signed-off-by: Zihao Gao <[email protected]>

PA sync: parse scan result for bttool

99037c4

bug: v/82379 Parse scan result at bttol to check if there is an Auracast source available. Signed-off-by: Zihao Gao <[email protected]>

PA sync: optimize logs at bttool.

99b396b

bug: v/82379 Skip logs that are not available. Add more debug logs on error. Signed-off-by: Zihao Gao <[email protected]>

PA sync: allow to stop scan

f75ec66

bug: v/82379 Allow to stop scanning for periodic advertisers. Signed-off-by: Zihao Gao <[email protected]>

PA sync: add flags in scan result

736fc64

bug: v/82820 Add an extra flag to indicate whether periodic advertising is present in the scan result. Signed-off-by: Zihao Gao <[email protected]>

LE Scan: modify message codes

d7c9c60

bug: v/82820 Modify message codes so its safe when client and server have different version of codes. Signed-off-by: Zihao Gao <[email protected]>

gzh-terry dismissed stale reviews from chengkai15 and zhongzhijie1 via d7c9c60 January 9, 2026 09:25

gzh-terry force-pushed the pa_sync branch from 4f65d20 to d7c9c60 Compare January 9, 2026 09:25

	MIN(sizeof(info->broadcast_name), data->len));
	MIN(sizeof(info->broadcast_name), data->len > 0 ? data->len - 1 : 0));

Add PA sync service #352

Are you sure you want to change the base?

Add PA sync service #352

Uh oh!

Conversation

gzh-terry commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huangyulong3 left a comment

Choose a reason for hiding this comment

Uh oh!

huangyulong3 left a comment

Choose a reason for hiding this comment

Uh oh!

huangyulong3 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

gzh-terry Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

gzh-terry Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gzh-terry commented Dec 29, 2025 •

edited

Loading