zblue: hfp: ag: fix mem leak #354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzh-terry
approved these changes
Jan 5, 2026
Contributor
gzh-terry
left a comment
gzh-terry
left a comment
There was a problem hiding this comment.
It's fine to me.
But we can actually do malloc right before strlcpy. So we can reduce the number of free(line).
gzh-terry
reviewed
Jan 5, 2026
Contributor
gzh-terry
left a comment
gzh-terry
left a comment
There was a problem hiding this comment.
And one more thing.
We can try to calculate the line_len first.
And malloc(line_len + 1) rather than malloc(HFP_AT_LEN_MAX + 1);
expliyh
force-pushed
the
82382
branch
2 times, most recently
from
90b5a12 to
9385cb0
Compare
expliyh
requested review from
chejinxian,
chengkai15,
jialu522,
liuX10,
voids701,
zhangyuan376 and
zhongzhijie1
as code owners
bug: v/82382 Rootcause: mem not free in some case. Signed-off-by: YuhengLi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/82382
Rootcause: mem not free in some case.