att over br modify patch by liuX10 · Pull Request #458 · open-vela/frameworks_bluetooth

liuX10 · 2026-02-10T02:33:22Z

No description provided.

…ts limit bug: v/84473 When the number of registered services exceeds the limit, records not captured by `gatt_sdp_records` will be returned. Subsequent attempts to locate pointer indices for release will fail. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>

…`bt_conn_lookup_addr_br`. bug: v/84474 1. Add a call to bt_conn_unref(conn) 2. Use the locally stored conn in the sal layer to avoid executing `bt_conn_unref` Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>

bug: v/84474 When the peer initiates a connection, the connection callback reporting logic lacks the `bt_conn_add` entry. This prevents the subsequent SAL layer from retrieving the corresponding `bt_conn_info_t` object for the address, leading to subsequent data transmission process failures. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>

bug: v/84474 When the SAL layer does not store the BREDR connection information, it returns info as NULL. At this point, attempting an erroneous address offset on info->conn will result in a null pointer return. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>

service/stacks/zephyr/sal_gatt_server_interface.c

zhongzhijie1

LGTM. The changes look good and address several issues:

Memory Management: Fixed potential memory leaks in gatt_sdp_create_record (freeing attrs and record on failure) and do_gatts_disconnect (adding bt_conn_unref).
Connection Tracking: zblue_gatts_connected_callback now uses bt_conn_add to ensure the connection is tracked and sets the GATT_ROLE_SERVER flag.
ATT over BR/EDR Support: The changes in send_response, send_notification, and send_indication correctly implement a fallback to look up BR/EDR connections when an LE connection is not found, which is consistent with the PR title.

Copilot

Pull request overview

This PR updates the Zephyr GATT server implementation to improve ATT-over-BR/EDR behavior, including connection bookkeeping and BR/EDR fallbacks when sending GATT responses/notifications/indications.

Changes:

Fix SDP record creation flow to return success only when a record slot is actually reserved; free allocations on failure.
Ensure BR/EDR disconnect path releases the bt_conn reference after lookup/disconnect.
Add BR/EDR connection fallback for server responses/notifications/indications when no LE connection is found, and ensure BR connection slots are created on connect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T02:37:16Z

service/stacks/zephyr/sal_gatt_server_interface.c

+    if (!slot->role) {
+        slot->role |= GATT_ROLE_SERVER;
+    }


slot->role is only updated when it is currently 0. If the connection slot already exists with GATT_ROLE_CLIENT set, this will skip setting GATT_ROLE_SERVER, leaving the role flags inconsistent for an ATT-over-BR server connection. Consider always OR-ing in GATT_ROLE_SERVER here (or using bt_conn_set_role() to merge roles consistently).

Suggested change

if (!slot->role) {

slot->role |= GATT_ROLE_SERVER;

}

slot->role |= GATT_ROLE_SERVER;

it is att over br, we have no gattc role to initial

Copilot · 2026-02-12T02:37:17Z

service/stacks/zephyr/sal_gatt_server_interface.c

+        bt_conn_info_t* info;
+        BT_LOGW("%s, le conn null", __func__);
+
+        info = bt_conn_find(addr, BT_TRANSPORT_BREDR);
+        conn = info ? info->conn : NULL;


For BR/EDR-only operation, get_le_conn_from_addr() will commonly be NULL; logging this as a warning can spam logs on every response. Consider lowering this to debug, or only warning after both LE and BR lookups fail.

Copilot · 2026-02-12T02:37:17Z

service/stacks/zephyr/sal_gatt_server_interface.c

+        bt_conn_info_t* info;
        BT_LOGW("%s, le conn null", __func__);

-        context.conn = bt_conn_lookup_addr_br((bt_addr_t*)addr);
+        info = bt_conn_find(addr, BT_TRANSPORT_BREDR);
+        context.conn = info ? info->conn : NULL;


For BR/EDR-only operation, get_le_conn_from_addr() being NULL is expected; logging it as a warning can spam logs for frequent notifications. Consider lowering this to debug, or only warning after both LE and BR lookups fail.

Copilot · 2026-02-12T02:37:18Z

service/stacks/zephyr/sal_gatt_server_interface.c

+        bt_conn_info_t* info;
        BT_LOGW("%s, le conn null", __func__);

-        context.conn = bt_conn_lookup_addr_br((bt_addr_t*)addr);
+        info = bt_conn_find(addr, BT_TRANSPORT_BREDR);
+        context.conn = info ? info->conn : NULL;
        if (!context.conn) {


For BR/EDR-only operation, get_le_conn_from_addr() being NULL is expected; logging it as a warning can spam logs for frequent indications. Consider lowering this to debug, or only warning after both LE and BR lookups fail.

zhongzhijie1 · 2026-02-12T03:13:43Z

service/stacks/zephyr/sal_gatt_server_interface.c

    }

-    return record;
+    free(attrs);


suggest add err log

zhongzhijie1 · 2026-02-12T03:26:42Z

service/stacks/zephyr/sal_gatt_server_interface.c

    context.conn = get_le_conn_from_addr(addr);
    if (!context.conn) {
+        bt_conn_info_t* info;
        BT_LOGW("%s, le conn null", __func__);


no le conn, find bredr conn

zhongzhijie1 · 2026-02-12T03:36:42Z

service/stacks/zephyr/sal_gatt_server_interface.c

-    slot = bt_conn_find(&addr, BT_TRANSPORT_BREDR);
+    slot = bt_conn_add(&addr, BT_TRANSPORT_BREDR);
    if (!slot) {
        BT_LOGE("%s, conn slot null", __func__);


huangyulong3 · 2026-02-12T03:56:50Z

service/stacks/zephyr/sal_gatt_server_interface.c

    context.conn = get_le_conn_from_addr(addr);
    if (!context.conn) {
+        bt_conn_info_t* info;
        BT_LOGW("%s, le conn null", __func__);


If this behavior is expected for BREDR, the LOG level here should not be set to warning; INFO is preferable.

zhongzhijie1

There are remaining actions. The issue is not in this PR.

liuX10 added 4 commits February 10, 2026 10:19

gatts: fix an issue where bt_conn_unref was not called after using …

8fee435

…`bt_conn_lookup_addr_br`. bug: v/84474 1. Add a call to bt_conn_unref(conn) 2. Use the locally stored conn in the sal layer to avoid executing `bt_conn_unref` Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>

liuX10 requested review from chengkai15, gzh-terry, huangyulong3, hyson710, zhangyuan376 and zhongzhijie1 as code owners February 10, 2026 02:33

chengkai15 reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

chengkai15 reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

chengkai15 reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

chengkai15 reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

gzh-terry reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

gzh-terry reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

gzh-terry reviewed Feb 10, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c Show resolved Hide resolved

zhongzhijie1 reviewed Feb 11, 2026

View reviewed changes

chengkai15 approved these changes Feb 11, 2026

View reviewed changes

zhongzhijie1 requested a review from Copilot February 12, 2026 02:33

Copilot started reviewing on behalf of zhongzhijie1 February 12, 2026 02:34 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

zhongzhijie1 reviewed Feb 12, 2026

View reviewed changes

service/stacks/zephyr/sal_gatt_server_interface.c

}

return record;

free(attrs);

Copy link

Contributor

zhongzhijie1 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest add err log

zhongzhijie1 reviewed Feb 12, 2026

View reviewed changes

huangyulong3 reviewed Feb 12, 2026

View reviewed changes

zhongzhijie1 approved these changes Feb 12, 2026

View reviewed changes

Comments

Conversation

liuX10 commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhongzhijie1 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zhongzhijie1 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zhongzhijie1 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zhongzhijie1 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zhongzhijie1 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

huangyulong3 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

zhongzhijie1 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants