Conversation
patrickswijgman
force-pushed
the
fix-use-exact-device-id
branch
2 times, most recently
from
51da2d5 to
ede9f44
Compare
Dagg-h
reviewed
Jan 20, 2026
puppeteer/package.json
Outdated
| "puppeteer": "^18.0.4" | ||
| }, | ||
| "dependencies": { | ||
| "sinon": "^7.5.0" |
Dagg-h
approved these changes
Jan 20, 2026
Collaborator
Dagg-h
left a comment
Dagg-h
left a comment
There was a problem hiding this comment.
If the unused package is removed, LGTM
Dagg-h
force-pushed
the
fix-use-exact-device-id
branch
from
ede9f44 to
32bb9cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number
{if exists provide related issue}
Expected behaviour
It select the input audio device you want
Actual behaviour
It does not select the input audio device you want because microphone permission got more strict in Google Chrome
Description of fix
Specifically request the exact device that we want
Other info
https://groups.google.com/g/discuss-webrtc/c/f2NdyxWjbN4/m/y50Xe1WoAAAJ