chore: update dependencies #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenbroekema
force-pushed
the
chore/update-deps
branch
from
8744c18 to
a79e8ca
Compare
|
Just found https://www.npmjs.com/package/fs-chmod, might try that |
jorenbroekema
force-pushed
the
chore/update-deps
branch
from
a79e8ca to
41f3e3c
Compare
|
Included in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some of the deps in one go instead of multiple renovate bot PRs.
One thing I could not update is Husky.
Husky now requires the hooks to be in
.shfiles which need execution permissions. Currently, create does not take into account permissions, so if you give it+xin the templates, and run the generator, those execute permissions are lost, meaning husky won't work for the end user.I couldn't find a straight-forward way to read out the octal permission code of a file. What NodeJS does let you do is check if it can execute, you could store that, but then it's kinda hard to add this permission upon writing file on disk, because
fs.chmodonly lets you pass full octal permission code, not something like+x😭 kinda sad that the Node fs module is pretty bad at permissions, compared to how easy it is with linux commands. So yeah, I left it out of this PR for now...