Skip to content

Fix/296 multiple packages #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix/296 multiple packages #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e03070
initial version
veith Feb 18, 2025
6b72cbb
test: pass all existing test cases
veith Feb 20, 2025
d7aebcb
test: add test for multi package bug
veith Feb 20, 2025
b81ba9c
Merge branch 'error/packages' into feat/packages
veith Feb 20, 2025
e2228db
fix: fixture
veith Feb 20, 2025
71ceb6c
fix: fixture
veith Feb 20, 2025
9954b40
fix: fixture
veith Feb 21, 2025
0e480a4
chore: comments
veith Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
dist/
.DS_Store
.idea

## Rocket ignore files
docs/_merged_data/
docs/_merged_assets/
docs/_merged_includes/
_site-dev
_site
/node_modules
/node_modules
188 changes: 188 additions & 0 deletions packages/analyzer/fixtures/02-inheritance/06-multiple-packages/fixture/custom-elements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
{
"schemaVersion": "1.0.0",
"readme": "",
"modules": [
{
"kind": "javascript-module",
"path": "my-element.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement",
"members": [
{
"kind": "field",
"name": "extClassProp",
"type": {
"text": "string"
},
"default": "'otherValueThanProp'"
},
{
"kind": "field",
"name": "extMixinProp",
"type": {
"text": "string"
},
"default": "'prop'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "extScoped",
"type": {
"text": "boolean"
},
"default": "true",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
],
"superclass": {
"name": "MyClass",
"package": "@ext-scoped/same-path/MyClass.js"
}
}
],
"exports": [
{
"kind": "js",
"name": "MyElement",
"declaration": {
"name": "MyElement",
"module": "my-element.js"
}
}
]
},
{
"kind": "javascript-module",
"path": "my-element2.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement2",
"members": [
{
"kind": "field",
"name": "extClassProp",
"type": {
"text": "string"
},
"default": "'otherValueThanProp'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "ThirdClassProp",
"type": {
"text": "string"
},
"default": "'three'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
],
"superclass": {
"name": "MyClass",
"package": "ext-pkg-without-export-map"
},
"attributes": [
{
"name": "ext-class-attr",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
]
}
],
"exports": [
{
"kind": "js",
"name": "MyElement2",
"declaration": {
"name": "MyElement2",
"module": "my-element2.js"
}
}
]
},
{
"kind": "javascript-module",
"path": "my-element3.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement3",
"superclass": {
"name": "MyClass",
"package": "@other-package/same-path/MyClass.js"
},
"members": [
{
"kind": "field",
"name": "extMixinProp",
"type": {
"text": "string"
},
"default": "'prop'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "shouldNotApear",
"type": {
"text": "string"
},
"default": "'no'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "otherPackage",
"type": {
"text": "boolean"
},
"default": "true",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
]
}
],
"exports": [
{
"kind": "js",
"name": "MyElement3",
"declaration": {
"name": "MyElement3",
"module": "my-element3.js"
}
}
]
}
]
}
188 changes: 188 additions & 0 deletions packages/analyzer/fixtures/02-inheritance/06-multiple-packages/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
{
"schemaVersion": "1.0.0",
"readme": "",
"modules": [
{
"kind": "javascript-module",
"path": "my-element.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement",
"members": [
{
"kind": "field",
"name": "extClassProp",
"type": {
"text": "string"
},
"default": "'otherValueThanProp'"
},
{
"kind": "field",
"name": "extMixinProp",
"type": {
"text": "string"
},
"default": "'prop'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "extScoped",
"type": {
"text": "boolean"
},
"default": "true",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
],
"superclass": {
"name": "MyClass",
"package": "@ext-scoped/same-path/MyClass.js"
}
}
],
"exports": [
{
"kind": "js",
"name": "MyElement",
"declaration": {
"name": "MyElement",
"module": "my-element.js"
}
}
]
},
{
"kind": "javascript-module",
"path": "my-element2.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement2",
"members": [
{
"kind": "field",
"name": "extClassProp",
"type": {
"text": "string"
},
"default": "'otherValueThanProp'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "ThirdClassProp",
"type": {
"text": "string"
},
"default": "'three'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
],
"superclass": {
"name": "MyClass",
"package": "ext-pkg-without-export-map"
},
"attributes": [
{
"name": "ext-class-attr",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
]
}
],
"exports": [
{
"kind": "js",
"name": "MyElement2",
"declaration": {
"name": "MyElement2",
"module": "my-element2.js"
}
}
]
},
{
"kind": "javascript-module",
"path": "my-element3.js",
"declarations": [
{
"kind": "class",
"description": "",
"name": "MyElement3",
"superclass": {
"name": "MyClass",
"package": "@other-package/same-path/MyClass.js"
},
"members": [
{
"kind": "field",
"name": "extMixinProp",
"type": {
"text": "string"
},
"default": "'prop'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "shouldNotApear",
"type": {
"text": "string"
},
"default": "'no'",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
},
{
"kind": "field",
"name": "otherPackage",
"type": {
"text": "boolean"
},
"default": "true",
"inheritedFrom": {
"name": "MyClass",
"module": "MyClass.js"
}
}
]
}
],
"exports": [
{
"kind": "js",
"name": "MyElement3",
"declaration": {
"name": "MyElement3",
"module": "my-element3.js"
}
}
]
}
]
}
1 change: 1 addition & 0 deletions packages/analyzer/fixtures/02-inheritance/06-multiple-packages/package/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!node_modules/
Loading