Remove unnecessary testing of support and add implement new syntax #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdwilliams
requested changes
Jul 25, 2024
|
|
||
| protected updated(changed: Map<string, unknown>): void { | ||
| if (changed.has('value') || changed.has('checked')) { | ||
| const checked: any = 'checked'; |
There was a problem hiding this comment.
Remove the type annotation it’s unnecessary and not accurate.
| states = this.internals.states, | ||
| // Casted to any, because the polyfill forces dashed-ident syntax https://github.com/calebdwilliams/element-internals-polyfill/issues/126 | ||
| // TODO: Remove any cast when the issue is resolved | ||
| state: any = 'show-error'; |
There was a problem hiding this comment.
Remove inaccurate type annotation.
There was a problem hiding this comment.
There's a comment and a TODO explaining why it's necessary. To make it work I should remove the import { IElementInternals } from "element-internals-polyfill"; from form-control types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
I've migrated the selectors to support both the new
:state(checked)and the old:--checkedselector leaving the polyfilled syntax intact.