feat: add gas limit #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Mar 26, 2025
poc/runtime/src/pvq.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn execute_query(query: &[u8], input: &[u8]) -> PvqResult { |
Member
There was a problem hiding this comment.
should take an optional gas limit as input to and max to like 2s of execution to prevent for people calling infinite loop
Contributor
Author
There was a problem hiding this comment.
Is the max execution time related to gas_limit or they are separately specified like execute_query(query: &[u8], input: &[u8], gas_limit: Option<i64>, ref_time_limit: u64)? I supposed they should be related.
Member
There was a problem hiding this comment.
the input is gas limit. by 2s I mean estimate how much gas can be consumed to execute a code that takes 2s to complete
xlc
reviewed
Mar 27, 2025
| impl pvq_runtime_api::PvqApi<Block> for Runtime { | ||
| fn execute_query(program: Vec<u8>, args: Vec<u8>, gas_limit: Option<i64>) -> pvq_primitives::PvqResult { | ||
| // Set a default gas limit of 2 seconds | ||
| pvq::execute_query(&program, &args, gas_limit.unwrap_or(ONE_SECOND_IN_GAS * 2)) |
Member
There was a problem hiding this comment.
if user did pass a gas limit, it should still not be greater than 2s
xlc
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.