-
Notifications
You must be signed in to change notification settings - Fork 0
0.6.7 updates #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.7 updates #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request introduces significant and wide-ranging updates to the protocol, including a major refactoring of privileged services, changes to state storage key handling, and a re-numbering of host call identifiers. The changes are largely consistent and well-implemented across the codebase. However, one specific change introduces an unexplained magic number that should be clarified.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 80.81% 81.17% +0.36%
==========================================
Files 376 376
Lines 32608 32935 +327
==========================================
+ Hits 26352 26736 +384
+ Misses 6256 6199 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request introduces significant refactoring and new features, including a redesign of privileged services, variable-length storage keys for service accounts, and several new economic parameters. The changes are mostly consistent, but I found one issue regarding a magic number in the storage footprint calculation that should be addressed for clarity and maintainability.
No description provided.