Skip to content

Conversation

@qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Aug 1, 2025

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request introduces significant and wide-ranging updates to the protocol, including a major refactoring of privileged services, changes to state storage key handling, and a re-numbering of host call identifiers. The changes are largely consistent and well-implemented across the codebase. However, one specific change introduces an unexplained magic number that should be clarified.

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 46.05263% with 369 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (0317131) to head (69cdabf).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../Blockchain/VMInvocations/HostCall/HostCalls.swift 13.86% 348 Missing ⚠️
...hain/Sources/Blockchain/Types/ServiceAccount.swift 5.88% 16 Missing ⚠️
...Invocations/InvocationContexts/RefineContext.swift 0.00% 2 Missing ⚠️
...cations/InvocationContexts/AccumulateContext.swift 0.00% 1 Missing ⚠️
JAMTests/Tests/JAMTests/w3f/AccumulateTests.swift 85.71% 1 Missing ⚠️
Utils/Sources/Utils/Crypto/Bandersnatch.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   80.81%   81.17%   +0.36%     
==========================================
  Files         376      376              
  Lines       32608    32935     +327     
==========================================
+ Hits        26352    26736     +384     
+ Misses       6256     6199      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qiweiii qiweiii marked this pull request as ready for review August 8, 2025 08:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request introduces significant refactoring and new features, including a redesign of privileged services, variable-length storage keys for service accounts, and several new economic parameters. The changes are mostly consistent, but I found one issue regarding a magic number in the storage footprint calculation that should be addressed for clarity and maintainability.

@xlc xlc merged commit b79efcb into master Aug 10, 2025
5 of 7 checks passed
@xlc xlc deleted the 0.6.7 branch August 10, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants