fuzz tests debug fix #351
fuzz tests debug fix #351
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 81.97% 81.98%
=======================================
Files 377 377
Lines 33022 33067 +45
=======================================
+ Hits 27071 27111 +40
- Misses 5951 5956 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes primarily consist of a beneficial refactoring that separates validation logic from state update logic across multiple runtime protocols. This improves code structure and testability. Additionally, the fuzz testing framework has been enhanced to better manage test cases, including those with expected failures. A few minor issues were found: a test was disabled by commenting out its body, a fixed-duration sleep was added to a test, which could indicate a potential race condition, and a debug log was added.
Suggestions that couldn't be attached to a specific line
Node/Tests/NodeTests/NodeTests.swift:117, 138
A fixed-duration Task.sleep has been added to fix a likely race condition. This can make tests slower and potentially flaky. A more robust solution would be to use a deterministic synchronization mechanism, like waiting on an expectation or notification, to confirm that block production is complete before proceeding.
|
|
||
| let codeHash: Data32? = try? Data32(state.readMemory(address: regs[0], length: 32)) | ||
|
|
||
| logger.debug("new codeHash: \(codeHash?.description ?? "nil")") |
There was a problem hiding this comment.
A debug log has been added. Please remove this temporary logging before merging.
| // await withKnownIssue("Invalid bandersnatch", isIntermittent: true) { | ||
| // try await TraceTest.test(input) | ||
| // } |
There was a problem hiding this comment.
The body of stfTests is commented out, effectively disabling it. To make the intent clear and ensure the test isn't forgotten, please use the testing framework's official mechanism for disabling tests, such as @Test(.disabled(reason: "Temporarily disabled due to invalid bandersnatch issue")).
Uh oh!
There was an error while loading. Please reload this page.