fix release build #355
fix release build #355
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # Build Swift release binary with our static libraries | ||
| swift build -c release \ | ||
| swift build -c release -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete \ |
There was a problem hiding this comment.
Disabling Swift compiler optimizations with -Xswiftc -Onone for a release build is a significant concern. While it may resolve the immediate build failure, it will result in a binary with substantially worse performance. The underlying code or dependency issue that causes failures with optimization should be investigated and fixed, rather than shipping an unoptimized release artifact.
| WORKDIR /boka/Boka | ||
|
|
||
| RUN swift build -c release | ||
| RUN swift build -c release -Xswiftc -Onone -Xswiftc -whole-module-optimization -Xswiftc -package-cmo -Xswiftc -unavailable-decl-optimization=complete |
There was a problem hiding this comment.
Similar to the workflow change, this disables Swift compiler optimizations (-Onone) for the Docker release build. This will negatively impact the performance of the application running in the container. The root cause of the optimization-related build failure should be identified to allow for a properly optimized release build.
There are inconsistency between debug and release build behavior (release build cannot pass tests), and disabling some optimization in release build makes it work